Closed
Bug 967779
Opened 11 years ago
Closed 11 years ago
replace persona icon with flat fox icon
Categories
(Firefox OS Graveyard :: FxA, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhirsch, Assigned: jhirsch)
Details
(Whiteboard: [fxa4fxos2.0])
Attachments
(6 files)
Waiting on jgruen to generate this asset, as seen in attached screengrab of wires
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
jgruen - hey, did we get an update from martell et al about the right icon to use?
Flags: needinfo?(jgruen)
Assignee | ||
Comment 2•11 years ago
|
||
We *could* ship without this. demoting.
Assignee | ||
Updated•11 years ago
|
Assignee: jgruen → nobody
Component: Gaia → FxA
Flags: needinfo?(jgruen)
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → 6a68
Assignee | ||
Comment 4•11 years ago
|
||
Ah, looks like the current version of the assets is gif, but almost all the icons in gaia currently seem to be png.
Arthur, should I update the icons_sprite*.gif files to be PNG, or just leave them as GIFs?
Flags: needinfo?(arthur.chen)
Assignee | ||
Comment 5•11 years ago
|
||
janx in IRC suggested I ask Carol (chuang@) instead, so, switching that now :-)
Flags: needinfo?(arthur.chen) → needinfo?(chuang)
Comment 6•11 years ago
|
||
Per https://bugzilla.mozilla.org/show_bug.cgi?id=840627#c8, using gif format is better in terms of the starting up performance. Not sure if it is still true now, but we should do a profiling before changing the format.
Comment 7•11 years ago
|
||
Hi Jared,
The attachment is the new sprite for Settings. I've switched the persona icon to Firefox icon.
Thanks!
Flags: needinfo?(chuang)
Assignee | ||
Updated•11 years ago
|
Priority: -- → P2
Updated•11 years ago
|
Whiteboard: [fxa4fxos2.0]
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Arthur Chen [:arthurcc] PTO: 5/19~5/21 from comment #6)
> Per https://bugzilla.mozilla.org/show_bug.cgi?id=840627#c8, using gif format
> is better in terms of the starting up performance. Not sure if it is still
> true now, but we should do a profiling before changing the format.
Cool, thanks Arthur. I'll just stick with the current setup, then.
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 8425600 [details]
Github PR 19448
Hey Arthur - Mind having a look at the updated sprite sheet? I've left it as gif to avoid spending extra time doing perf tests on png vs gif. Thanks! Jared
Attachment #8425600 -
Flags: review?(arthur.chen)
Comment 13•11 years ago
|
||
Comment on attachment 8425600 [details]
Github PR 19448
It seems the new icon has been added in bug 947985. Jared, could you check if the current icon is as your expectation? If yes, let's simply close this bug.
Attachment #8425600 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 14•11 years ago
|
||
Nice! Good catch, Arthur. Flashed master on my Flame, and the icon looks just like it should.
Closing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•