Closed Bug 967779 Opened 11 years ago Closed 11 years ago

replace persona icon with flat fox icon

Categories

(Firefox OS Graveyard :: FxA, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhirsch, Assigned: jhirsch)

Details

(Whiteboard: [fxa4fxos2.0])

Attachments

(6 files)

Waiting on jgruen to generate this asset, as seen in attached screengrab of wires
Assignee: nobody → jgruen
Blocks: 967622
Blocks: 974121
No longer blocks: 967622
Blocks: 987416
No longer blocks: 974121
jgruen - hey, did we get an update from martell et al about the right icon to use?
Flags: needinfo?(jgruen)
We *could* ship without this. demoting.
Blocks: 996054
No longer blocks: 987416
Assignee: jgruen → nobody
Component: Gaia → FxA
Flags: needinfo?(jgruen)
No longer blocks: 996054
Assignee: nobody → 6a68
Ah, looks like the current version of the assets is gif, but almost all the icons in gaia currently seem to be png. Arthur, should I update the icons_sprite*.gif files to be PNG, or just leave them as GIFs?
Flags: needinfo?(arthur.chen)
janx in IRC suggested I ask Carol (chuang@) instead, so, switching that now :-)
Flags: needinfo?(arthur.chen) → needinfo?(chuang)
Per https://bugzilla.mozilla.org/show_bug.cgi?id=840627#c8, using gif format is better in terms of the starting up performance. Not sure if it is still true now, but we should do a profiling before changing the format.
Attached file fox_sprite.zip (deleted) —
Hi Jared, The attachment is the new sprite for Settings. I've switched the persona icon to Firefox icon. Thanks!
Flags: needinfo?(chuang)
Priority: -- → P2
Whiteboard: [fxa4fxos2.0]
(In reply to Arthur Chen [:arthurcc] PTO: 5/19~5/21 from comment #6) > Per https://bugzilla.mozilla.org/show_bug.cgi?id=840627#c8, using gif format > is better in terms of the starting up performance. Not sure if it is still > true now, but we should do a profiling before changing the format. Cool, thanks Arthur. I'll just stick with the current setup, then.
Attached file Github PR 19448 (deleted) —
Comment on attachment 8425600 [details] Github PR 19448 Hey Arthur - Mind having a look at the updated sprite sheet? I've left it as gif to avoid spending extra time doing perf tests on png vs gif. Thanks! Jared
Attachment #8425600 - Flags: review?(arthur.chen)
Comment on attachment 8425600 [details] Github PR 19448 It seems the new icon has been added in bug 947985. Jared, could you check if the current icon is as your expectation? If yes, let's simply close this bug.
Attachment #8425600 - Flags: review?(arthur.chen)
Nice! Good catch, Arthur. Flashed master on my Flame, and the icon looks just like it should. Closing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: