Instead of the "Settings > Developer > Show devtools overlay" checkbox, the tracked metrics in the devtools layers should be configurable with prefs, in a "Devtools overlay" submenu. For example, a developer should be able to activate the errors, warnings and reflow widgets, but leave out the memory tracking widget. Additionally, it could also be nice to configure which apps are being tracked (e.g. none, just an app with a specific manifest, only certified, or all apps).

Gaia patch. Vivien, care to take a look?

A screenshot of the Developer HUD sub-menu.

Better screenshot.

TODO: - Don't show Grid, FPS and TTL if Developer HUD. - Gecko-side patch respecting Errors, Warnings and Reflows prefs.

> - Don't show Grid, FPS and TTL if Developer HUD. ... is disabled.

Comment on attachment 8372393 [details] gaia pull request Comments on github.

Comment on attachment 8374622 [details] [diff] [review] Make B2G devtools overlay metrics configurable with prefs. r=ochameau This should do the trick. Alex, could you please have a look?

Comment on attachment 8372393 [details] gaia pull request Thanks a lot for the feedback Vivien! I updated the pull request addressing the nits, killing the grid, and visually showing that FPS and TTL are not yet controlled by the same mechanism as Reflows/Warnings/Errors (disabling the Developer HUD only disables the latter 3 checkboxes).

Comment on attachment 8374622 [details] [diff] [review] Make B2G devtools overlay metrics configurable with prefs. r=ochameau Review of attachment 8374622 [details] [diff] [review]: ----------------------------------------------------------------- Stealing the review since ochameau is out for a few days. ::: b2g/chrome/content/devtools.js @@ +208,5 @@ > */ > let consoleWatcher = { > > _apps: new Map(), > + _watching: { reflows: false, warnings: false, errors: false }, Would be better for the blame history in the future if those are on multiple lines. @@ +215,5 @@ > init: function cw_init(client) { > this._client = client; > this.consoleListener = this.consoleListener.bind(this); > > + ['reflows', 'warnings', 'errors'].forEach(metric => { You can probably iterate on the this._watching map. @@ +283,3 @@ > if (pageError.warning || pageError.strict) { > + > + // WARNING Sounds useless (same for the rest of those comments). @@ +283,4 @@ > if (pageError.warning || pageError.strict) { > + > + // WARNING > + if (!this.bump(app, 'warnings')) { The name |bump| seems like a little lie now. Any reason to not have a shouldBump method or anything like that.

Comment on attachment 8374622 [details] [diff] [review] Make B2G devtools overlay metrics configurable with prefs. r=ochameau Thanks for the review! Nits addressed. > The name |bump| seems like a little lie now. Any reason to not have a shouldBump method or anything like > that. I believe "bump" can also be a synonym for "update", and I see it as a function that can refuse to comply, thus the `if (!) return`.

(In reply to Jan Keromnes [:janx] from comment #12) > Comment on attachment 8374622 [details] [diff] [review] > Make B2G devtools overlay metrics configurable with prefs. r=ochameau > > Thanks for the review! Nits addressed. > > > The name |bump| seems like a little lie now. Any reason to not have a shouldBump method or anything like > > that. > > I believe "bump" can also be a synonym for "update", and I see it as a > function that can refuse to comply, thus the `if (!) return`. Could be my international broken english that fails :)

It looks from the dev-doc-needed that this is the bug to document this. I'm having trouble figuring out how to get this working on my buri/hamachi device, so I suspect whoever tries to document this will have trouble too without more information. On trunky gaia (local checkout, engineer install)/gecko (engineer build), even with a "DEVICE_DEBUG=1 make reset-gaia" and reboots after using the GUI, I am unable to get the developer HUD to show up. Specifically, I never get cool squares in the lower right. The "Frames per second" checkbox does seem to control the 3 purple FPS-y numbers in the upper left (after reboot), and the "Time to load" checkbox does seem to immediately control the TTL widget's visibility. Can someone provide details on the steps/requirements to get this working? Thanks! needinfo'ing :janx as very likely having gotten this working having implemented it ;)

Hi Andrew, - Currently, the Developer HUD only works for non-certified apps like the Marketplace. This limitation is due to bug 962577. You can work around it by setting the "devtools.debugger.forbid-certified-apps" pref to false. - However, the "Frames per second" and "Time to load" widgets are special: they currently use a different code path, work on certified and non-certified apps, and disabling the whole Developer HUD doesn't make them go away. These issues are being worked on, and hopefully things will soon make more sense!

(In reply to Jan Keromnes [:janx] from comment #17) > - Currently, the Developer HUD only works for non-certified apps like the > Marketplace. This limitation is due to bug 962577. You can work around it by > setting the "devtools.debugger.forbid-certified-apps" pref to false. > > - However, the "Frames per second" and "Time to load" widgets are special: > they currently use a different code path, work on certified and > non-certified apps, and disabling the whole Developer HUD doesn't make them > go away. Ah, I think these two things explain exactly what I was seeing! Things didn't work initially because I had only turned on FPS. When I did reset-gaia to get things to work, I lost the certified app debugging. Things are working now that I have done reset-gaia again and put the certified apps pref back in. Thanks for the clarification!