Closed
Bug 969792
Opened 11 years ago
Closed 4 years ago
Some about: pages should show Firefox identity block
Categories
(Firefox :: Site Identity, defect, P5)
Tracking
()
RESOLVED
DUPLICATE
of bug 1567443
People
(Reporter: ntim, Unassigned)
References
Details
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
Many other about: pages are affected by this problem :
about:
about:about
about:customizing
about:downloads
... and many other. I can't make a full list, but you can check about:about.
Comment 2•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #1)
> Many other about: pages are affected by this problem :
Confirmed 30.0a1 (2014-02-10), win 7 x64
Status: UNCONFIRMED → NEW
Component: Sync → Location Bar
Ever confirmed: true
Updated•11 years ago
|
Severity: enhancement → normal
Updated•11 years ago
|
Summary: about:accounts should show Firefox identity block → about: pages should show Firefox identity block
Reporter | ||
Comment 3•11 years ago
|
||
Some about pages do show it properly though.
Summary: about: pages should show Firefox identity block → Some about: pages should show Firefox identity block
Comment 4•11 years ago
|
||
Thanks for the report, didn't notice this one before "hooking up" bug 970382 so duping forward :/
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Comment 5•11 years ago
|
||
Oops, didn't realize you made this more generic. We should come up with a non-whitelist solution for "chromeWhitelist" (http://hg.mozilla.org/mozilla-central/annotate/d8d8fa98ee7d/browser/base/content/browser.js#l6421).
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #5)
> Oops, didn't realize you made this more generic. We should come up with a
> non-whitelist solution for "chromeWhitelist"
> (http://hg.mozilla.org/mozilla-central/annotate/d8d8fa98ee7d/browser/base/
> content/browser.js#l6421).
Maybe a regex ?
Comment 7•11 years ago
|
||
A regex that matches what?
The difficulty is that there are some pages that should be included (all the built-in Firefox ones that users are likely to encounter) and some that we felt shouldn't (pages added by add-ons, internal pages that aren't meant to be exposed, etc.), and there are no easy ways to distinguish them.
A whitelist gets out of date, a blacklist wouldn't exclude all add-on pages. We could perhaps add a separate nsIAboutModule flag for pages to opt in to the special identity block behavior, but that is likely to be accidentally misused by add-ons just coping nsIAboutModule implementations from Firefox.
The brute force solution is to just update the whitelist periodically as we add new about: pages (e.g. bug 970382).
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to :Gavin Sharp (email gavin@gavinsharp.com) from comment #7)
> A regex that matches what?
>
> The difficulty is that there are some pages that should be included (all the
> built-in Firefox ones that users are likely to encounter) and some that we
> felt shouldn't (pages added by add-ons, internal pages that aren't meant to
> be exposed, etc.), and there are no easy ways to distinguish them.
>
> A whitelist gets out of date, a blacklist wouldn't exclude all add-on pages.
> We could perhaps add a separate nsIAboutModule flag for pages to opt in to
> the special identity block behavior, but that is likely to be accidentally
> misused by add-ons just coping nsIAboutModule implementations from Firefox.
>
> The brute force solution is to just update the whitelist periodically as we
> add new about: pages (e.g. bug 970382).
For the add-on problem, Firefox could force the addons to use a new add-on:// or extension:// scheme.
For the internal pages, maybe Firefox could use a new about-internal:// scheme or change to the current chrome:// scheme.
Then a regex that would check for pages beginning with about: would be the solution.
Reporter | ||
Comment 9•11 years ago
|
||
It's hard, but I see no better choice.
Comment 10•7 years ago
|
||
this is probably feasible now that add-ons are out of the way.
Priority: -- → P5
Updated•4 years ago
|
Component: Address Bar → Site Identity
Updated•4 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 4 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•