Closed
Bug 973332
Opened 11 years ago
Closed 11 years ago
Add "leave-open" keyword support to mcMerge
Categories
(Tree Management :: Bugherder, defect)
Tree Management
Bugherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: graememcc, Assigned: graememcc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
emorley
:
review+
RyanVM
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8376823 -
Flags: review?(ryanvm)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8376823 [details] [diff] [review]
Patch
LGTM from what I can tell, but I'd prefer if Ed took a look at this too as someone's who a bit more competent at this :)
Attachment #8376823 -
Flags: review?(ryanvm)
Attachment #8376823 -
Flags: review?(emorley)
Attachment #8376823 -
Flags: feedback+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8376823 [details] [diff] [review]
Patch
Looks good and works locally at least for the whiteboard behaviour still. Thank you for doing this :-)
Attachment #8376823 -
Flags: review?(emorley) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → graememcc_firefox
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
||
Comment 5•11 years ago
|
||
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•11 years ago
|
||
Looks like it's working well. I just merged a bug with the keyword set and mcMerge is properly handling it. Can we send a note to dev-platform making mention of this change?
|
|
||
Comment 7•11 years ago
|
||
This is fodder for a new bug, but we may want some visible indication in the UI that leave-open is set on the bug. We sorta had that before because the whiteboard is visible, but we don't see what keywords are set.
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> Can we send a note to dev-platform making mention of this change?
Done. Currently held in moderation, should show up eventually.
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> This is fodder for a new bug, but we may want some visible indication in the
> UI that leave-open is set on the bug.
Ah, good point. Bug 974838.
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Component: TBPL → mcMerge
You need to log in
before you can comment on or make changes to this bug.
Description
•