XPIProvider defines two generic zip extraction methods that, if exposed, could be reused elsewhere in the code base. They should be extracted into a new ZipUtils.jsm module.

Comment on attachment 8378436 [details] [diff] [review] Refactor XPIProvider's private zip utilities into a ZipUtils.jsm to make them reusable. Dave, care to take a look?

Comment on attachment 8378436 [details] [diff] [review] Refactor XPIProvider's private zip utilities into a ZipUtils.jsm to make them reusable. Breaking this into its own module means we should probably have a few tests for it, separate from the add-ons manager stuff.

Comment on attachment 8387645 [details] [diff] [review] Refactor XPIProvider's private zip utilities into a ZipUtils.jsm. r=Mossop Rebased, fixed, added tests, ready for round #2.

Comment on attachment 8387645 [details] [diff] [review] Refactor XPIProvider's private zip utilities into a ZipUtils.jsm. r=Mossop I'm assuming the code in the module is just a straight copy/paste with no other changes. If there are please flag them for me and ask for review again otherwise this is good to go.

Thanks for the review Dave! The move was mostly a straight cut & paste, but I had to modify a few minor things (function structure and logging). Flagging you on these changes just in case.

Comment on attachment 8389119 [details] [diff] [review] changes.diff Review of attachment 8389119 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks good.

Comment on attachment 8389119 [details] [diff] [review] changes.diff Great, thanks Dave! Marking diff as obsolete to avoid confusions.