Closed Bug 981482 Opened 11 years ago Closed 8 years ago

Allow installing local app with zip package from the app manager UI

Categories

(DevTools Graveyard :: WebIDE, defect, P3)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: xyuan, Unassigned, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Currently if we want to install an app packaged with a zip file, we should unzip the file to a directory, and then install the app for the directory. I expect we can install the packaged app directly without unzipping. I can try to take this bug if nobody want :-)
I'm doing something similar for the "Create New App" button in bug #968808, because it downloads templates from the web and extracts them. That's why I implemented a ZipUtils.jsm in bug #974498 with the methods `extractFiles(aZipFile, aDir)` and `extractFilesAsync(aZipFile, aDir)`. This could now be used by the App Manager to address this bug. Maybe http://dxr.mozilla.org/mozilla-central/source/browser/devtools/app-manager/content/projects.js#99 can be refactored to accept zip files as well as folders? If provided a zip file, the method should prompt the user a second time to get a destination folder.
Jan, thanks. Let me start working on it;)
Assignee: nobody → xyuan
Status: NEW → ASSIGNED
Sure! Please ping me if you are able to move forward on this, or if you have any question.
Whiteboard: mentor=janx
Good idea, that would give developers a good way to do a test before submitting to the marketplace.
Hi Yuan, were you able make some progress on this? Please let me know if you are stuck / have questions! :)
Flags: needinfo?(xyuan)
Jan, thanks. I'll provide a patch for priliminary review soon. I didn't have enough time to work on last week. So it was delayed.
Flags: needinfo?(xyuan)
I would like to see this implemented as well. So my question is: Are there any news regarding the status of this bug? :yxl Have you made progress on implementing .zip-file support?
This will need to wait until we land the new UI. Question: do we want to unzip the file somewhere and do the validation and show the source code, or directly push without further operations?
Depends on: 999417
Felix, in the new UI we added a feature to create new apps from templates. The code is mostly the same as in bug 968808, which uses `ZipUtils.extractFiles(target, folder)` as imported from http://dxr.mozilla.org/mozilla-central/source/toolkit/modules/ZipUtils.jsm Since the new UI adds support for handling zip files, :yxl will be able to use that to support importing archives. (In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #8) > This will need to wait until we land the new UI. > > Question: do we want to unzip the file somewhere and do the validation and > show the source code, or directly push without further operations? I think we want to import the app as a new project, show the sources, validate etc. This will be handy for sending projects around (e.g. downloading a zip file from github, MDN, bugzilla, sending an app per email, etc) and allowing you to work on them / debug / try to reproduce a bug etc.
(In reply to Jan Keromnes [:janx] from comment #9) > I think we want to import the app as a new project, show the sources, > validate etc. This will be handy for sending projects around (e.g. > downloading a zip file from github, MDN, bugzilla, sending an app per email, > etc) and allowing you to work on them / debug / try to reproduce a bug etc. Should we ask where to unzip it or should we unzip it next to the zip file?
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #10) > Should we ask where to unzip it or should we unzip it next to the zip file? I'd prefer we ask where to unzip it. Example: I download a zip file from the web, it lands in my Downloads/ folder, and I import it into the App Manager. It would be annoying that the project was unzipped in my Downloads/ folder, which I might empty later unknowingly.
(In reply to Jan Keromnes [:janx] from comment #11) > (In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from > comment #10) > > Should we ask where to unzip it or should we unzip it next to the zip file? > > I'd prefer we ask where to unzip it. Example: I download a zip file from the > web, it lands in my Downloads/ folder, and I import it into the App Manager. > It would be annoying that the project was unzipped in my Downloads/ folder, > which I might empty later unknowingly. WFM
I want to start working on FxStumbler which builds the app's zip from the working directory. But I cannot use the working directory as the js and css files will be concatenated, so that there are only 2 files the index.html file needs to load later on. Would be enough for me to import/install the zip app version onto the simulator/another external device by using the OS temp folder for zip extraction -> maybe you can offer both options: -install -extract and install
Mentor: janx
Whiteboard: mentor=janx
Assignee: xyuan → nobody
Status: ASSIGNED → NEW
Priority: -- → P4
Filter on TEAPOT-SPLINES.
Priority: P4 → P3
Whiteboard: [btpp-backlog]
Apps are being removed with B2G cleanup.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.