Closed
Bug 975292
Opened 11 years ago
Closed 11 years ago
[DSDS] "SIM 01" and "SIM 11" names are used in PIN changed successful toast messages instead of "SIM 1" and "SIM 2".
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
People
(Reporter: echu, Assigned: eragonj)
Details
(Whiteboard: dsdsrun1.4)
Attachments
(4 files)
After changed SIM 1 or SIM 2 PIN code, there will be successful messages but it calls the 2 SIM cards "SIM 01" and "SIM 11". * Build Number Fugu Gaia 35365feace970bfc51276428f40a477c9c86b7bb Gecko 048505064d4b8779cd17c820cebb377e0716ef16 BuildID 20140221061554 Version 30.0a1 * Reproduce Steps 1. Enable both SIM cards PIN. 2. Change SIM 1 PIN code. [1] 3. Change SIM 2 PIN code. [2] * Expected Result [1] "SIM 1 PIN changed successfully" toast message shows up. [2] "SIM 2 PIN changed successfully" toast message shows up. * Actual Result [1] "SIM 01 PIN changed successfully" toast message shows up. [2] "SIM 11 PIN changed successfully" toast message shows up. * Occurrence rate 100%
Comment 3•11 years ago
|
||
Triage: Plus this bug because this bug affect the DSDS v1.4 work in bug 948584
blocking-b2g: 1.4? → 1.4+
Comment 4•11 years ago
|
||
EJ, Please help on this 1.4 blocker. Raise you hand if you are overloaded. Thanks!
Assignee: nobody → ejchen
Assignee | ||
Comment 6•11 years ago
|
||
Arthur, this is a one-line patch. Please give me an r+ xD.
Attachment #8381245 -
Flags: review?(arthur.chen)
Comment 7•11 years ago
|
||
Comment on attachment 8381245 [details]
patch
Thanks for the quick response! As we expect cardIndex to be a number everywhere, I think it would be better to make it as a number in the very beginning.
Attachment #8381245 -
Flags: review?(arthur.chen)
Comment 8•11 years ago
|
||
Comment on attachment 8381245 [details]
patch
Checked the change, r=me. Please land the patch when travis green, thanks!
Attachment #8381245 -
Flags: review+
Assignee | ||
Comment 9•11 years ago
|
||
Thanks all, this patch just got merged onto gaia/master: 5534725dbc8245070cd8c40bd4150cfaef306474
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(ejchen)
Resolution: --- → FIXED
Reporter | ||
Comment 10•11 years ago
|
||
Verified on Fugu. Fugu Gaia 90673159ea569170109678646b01349620b5a941 Gecko e8b0013422e7cdc7d0d23d3ed99c47bd0fe88d72 BuildID 20140227075828 Version 30.0a1
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•