Francisco Jordano [:arcturus] [:francisco] Reporter
	Description • 11 years ago

+++ This bug was initially created as a clone of Bug #975691 +++

Right now the messages from an import operation (from sdcard, sim, or any other source), end with a message of the number of contacts read from that source.

Since version 1.2 we have automatic passive merging, which could lead to situations where  we don't have any contact in the list, read 12 contacts (from the sim card, a vcf, etc) and we end up in the list with (for example) 10.

The two 'missing' contacts are not really missing, since the algorithm for automatic merging was working behind scenes, merging for us contacts that we consider are the same (there are rules for that).

Basically the message says 12 contacts imported, and we should be more clear on the message. Julien has suggested something that works pretty well for me, it's extend that information with something like:

10 imported contacts
2 merged contacts

To keep the user informed of what really happened in the process

	Noemí Freire (:noemi)
	Comment 1 • 11 years ago

ni to UX in order to know their PoV here. Thanks!

	ayman maat :maat
	Comment 2 • 11 years ago

(In reply to Francisco Jordano [:arcturus] from comment #0)
> +++ This bug was initially created as a clone of Bug #975691 +++
> 
> Right now the messages from an import operation (from sdcard, sim, or any
> other source), end with a message of the number of contacts read from that
> source.
> 
> Since version 1.2 we have automatic passive merging, which could lead to
> situations where  we don't have any contact in the list, read 12 contacts
> (from the sim card, a vcf, etc) and we end up in the list with (for example)
> 10.
> 
> The two 'missing' contacts are not really missing, since the algorithm for
> automatic merging was working behind scenes, merging for us contacts that we
> consider are the same (there are rules for that).
> 
> Basically the message says 12 contacts imported, and we should be more clear
> on the message. Julien has suggested something that works pretty well for
> me, it's extend that information with something like:
> 
> 10 imported contacts
> 2 merged contacts
> 
> To keep the user informed of what really happened in the process


This is a very very good point and this lack of messaging is an oversight by me in the design of the merging functionality. We should prioritise this as it will lead to user orientation issues. 

From a UX PoV the messaging suggested here by Julien and Francisco is a suitable solution to keep the user informed and orientated. I would just propose a small alteration the wording as follows:

      10 imported contacts
      2 contacts merged

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 3 • 11 years ago

(In reply to ayman maat :maat from comment #2) 
> 
> From a UX PoV the messaging suggested here by Julien and Francisco is a
> suitable solution to keep the user informed and orientated. I would just
> propose a small alteration the wording as follows:
> 
>       10 imported contacts
>       2 contacts merged

In some cases (like FB, Gmail and Outlook), we could also remove friends, since we can 'unmark' contacts. So I guess we will have the possible:

10 imported contacts
2 contacts merged
10 contacts deleted

Perhaps a bit too much, but definitely will add all the info the user needs to know.

	Preeti Raghunath(:Preeti)
	Comment 4 • 11 years ago

Wilfred,

Please help get this on the roadmap for upcoming release.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 5 • 10 years ago

included in 1.5 comms targetted

	Wilfred Mathanaraj [:WDM]
	Comment 6 • 10 years ago

this is in the target list of 1.5

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 7 • 10 years ago

Hi, 

I'd suggest showing 

12 imported contacts
Merge 2 duplicated contacts

If we show "10" as imported contacts, users might get confused because they think they already imported 12. Hence, I think we shall provide more details on this string.

However, I'm quite lost on the "delete" scenario. Can you please give me more information on this case? Thanks!

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 8 • 10 years ago

Hi Carrie!

In the case of Fb, Gmail and outlook, we present a preview list of contacts to click on them to import, but also to click on them to remove from your list.

So, for example you can click in import contacts and unselect some of the contacts previously selected which will end up with us removing from the contacts list those contacts.

That's why I was suggesting to include the message for deletion as well.

Does it makes sense?

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 9 • 10 years ago

Hi Francisco, 
I've been thinking about this question and found out the behaviour of deleting the contacts while deselect the imported ones is really weird. Even if we provide the string to inform users that some contacts are deleted, they will never figure out the rule. Hence, I'd suggest gray-out those imported contacts so that users won't deselect them and accidentally cause the deletion. If they want to delete any contacts, they shall edit it in Contact APP. What do you say? Is it doable?

In addition, I've check the grammar of the string. :p It should be:

12 imported contacts
2 duplicated contacts merged

Thanks!

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 10 • 10 years ago

Sorry! that should be

12 contacts imported
2 duplicated contacts merged

Thanks!

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 11 • 10 years ago

Hei Carrie,

now that we have the edit mode in contacts, your proposal makes sense to me.

So I'll suggest to keep this bug, do the new information display with imported and merged, and open a new bug to proceed with your suggestion about gray out the contacts already imported.

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 12 • 10 years ago

Just opened bug 999966 for removing that behavior.

Thanks.

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 13 • 10 years ago

Got it. Thanks! :)

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 14 • 10 years ago

If there is 12 contacts imported and none of them can be merged with existing contacts, then we display the string:

12 imported contacts

Thanks!

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 16 • 10 years ago

Comment on attachment 8433924 [details]
19982.html

Pretty awesome work Jose.

Left some minor comments on the PR.

Could we add unit tests to this please?

	Francisco Jordano [:arcturus] [:francisco] Reporter
	Comment 17 • 10 years ago

Comment on attachment 8433924 [details]
19982.html

Great work, and green travis :)

	Jose Manuel Cantera Assignee
	Comment 18 • 10 years ago

https://github.com/mozilla-b2g/gaia/commit/d283b742a12ac43ec087f45b02d3817cf7ddab69

	Loli (:lolimartinezcr)
	Comment 19 • 10 years ago

Pending bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1021548

	Loli (:lolimartinezcr)
	Comment 20 • 10 years ago

Tested and working:
2.0
Hamachi
Gecko-e50f6b7
Gaia-3bfe47c