Closed
Bug 980339
Opened 11 years ago
Closed 10 years ago
about:addons squaring
Categories
(Toolkit :: Themes, defect)
Tracking
()
VERIFIED
FIXED
mozilla31
Tracking | Status | |
---|---|---|
firefox29 | --- | verified disabled |
firefox30 | --- | verified |
firefox31 | --- | verified |
People
(Reporter: Terepin, Assigned: ntim)
References
Details
(Whiteboard: [Australis:P-])
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
ntim
:
review+
ntim
:
superreview+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release) Build ID: 20140306030201 Steps to reproduce: Add-ons list and section selector needs to be squared and not rounded.
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
Comment 1•11 years ago
|
||
Not tracking for Australis, but we'd of course take your patch. :)
Whiteboard: [Australis:P-]
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Updated•11 years ago
|
Blocks: theme-win8
Assignee | ||
Comment 2•11 years ago
|
||
Gonna give a try at this. I'm going to submit a pull request on Github soon.
Assignee | ||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•10 years ago
|
||
This patch is just for Windows 8, since I see no point of squaring borders for Windows Aero.
Attachment #8395276 -
Flags: review?(mdeboer)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8395276 [details] [diff] [review] bug_980339.patch Review of attachment 8395276 [details] [diff] [review]: ----------------------------------------------------------------- Looking good, except for the media queries you used. ::: toolkit/themes/windows/global/inContentUI.css @@ +73,5 @@ > %ifdef WINDOWS_AERO > @media (-moz-windows-glass) { > + *|*.main-content { > + border-radius: 5px; > + } I think (-moz-windows-glass) is too restrictive. The pattern we use to enable styles on other vista and 7 is ```css %ifdef WINDOWS_AERO @media (-moz-os-version: windows-vista), (-moz-os-version: windows-win7) { /* do stuff... */ } %endif ``` Please use this one instead. ::: toolkit/themes/windows/mozapps/extensions/extensions.css @@ +194,1 @@ > } Same here.
Attachment #8395276 -
Flags: review?(mdeboer) → feedback+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8395276 -
Attachment is obsolete: true
Attachment #8397266 -
Flags: review?(mdeboer)
Comment 6•10 years ago
|
||
Comment on attachment 8397266 [details] [diff] [review] Patch v2 Review of attachment 8397266 [details] [diff] [review]: ----------------------------------------------------------------- Please see my comment in bug 980418.
Attachment #8397266 -
Flags: review?(mdeboer)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8397266 -
Attachment is obsolete: true
Attachment #8397936 -
Flags: review?(mdeboer)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8397936 [details] [diff] [review] Patch v3 Forgot to change something
Attachment #8397936 -
Flags: review?(mdeboer)
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8397938 -
Flags: review?(mdeboer)
Assignee | ||
Updated•10 years ago
|
Attachment #8397936 -
Attachment is obsolete: true
Comment 10•10 years ago
|
||
Comment on attachment 8397938 [details] [diff] [review] Patch v4 Review of attachment 8397938 [details] [diff] [review]: ----------------------------------------------------------------- r=me with my last comment fixed (please upload a new patch for that.) Thanks! ::: toolkit/themes/windows/global/inContentUI.css @@ +78,5 @@ > + border-radius: 5px; > + } > +%ifdef WINDOWS_AERO > +} > +%endif You may remove the ``` %endif %ifdef WINDOWS_AERO ``` These preprocessor blocks are like a markup language of sorts; you opened a WINDOWS_AERO section before, so you don't need to close it and open it again right after closing it.
Attachment #8397938 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Yup, didn't notice it was duplicated. Btw, do you know how to make a "shortcut" in Mozilla build ? I'd like to be able to open the files with sublime text directly in mozilla build (instead of using gvim). For now, I have to navigate to the file directory then open the file with sublime text which isn't convenient.
Attachment #8397938 -
Attachment is obsolete: true
Attachment #8398578 -
Flags: review?(mdeboer)
Comment 12•10 years ago
|
||
Comment on attachment 8398578 [details] [diff] [review] Patch v5 Review of attachment 8398578 [details] [diff] [review]: ----------------------------------------------------------------- Following official policy, requesting s-r from a toolkit peer. ::: toolkit/themes/windows/global/inContentUI.css @@ +77,5 @@ > + *|*.main-content { > + border-radius: 5px; > + } > +%ifdef WINDOWS_AERO > +} nit: please keep the empty newline here.
Attachment #8398578 -
Flags: superreview?(bmcbride)
Attachment #8398578 -
Flags: review?(mdeboer)
Attachment #8398578 -
Flags: review+
Updated•10 years ago
|
Attachment #8398578 -
Flags: superreview?(bmcbride) → superreview+
Assignee | ||
Comment 13•10 years ago
|
||
Same as Patch v5, but with new line break.
Attachment #8398578 -
Attachment is obsolete: true
Attachment #8400123 -
Flags: superreview+
Attachment #8400123 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 14•10 years ago
|
||
Pushed as: https://hg.mozilla.org/integration/fx-team/rev/b53faee9792e
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
Keywords: checkin-needed
Whiteboard: [Australis:P-] → [Australis:P-][fixed-in-fx-team]
Comment 15•10 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #12) > Comment on attachment 8398578 [details] [diff] [review] > Patch v5 > > Review of attachment 8398578 [details] [diff] [review]: > ----------------------------------------------------------------- > > Following official policy, requesting s-r from a toolkit peer. Official policy is to get review from a peer. super-review is something different: http://www.mozilla.org/hacking/reviewers.html
Comment 16•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #15) > Official policy is to get review from a peer. super-review is something > different: http://www.mozilla.org/hacking/reviewers.html Duly noted, will remember.
https://hg.mozilla.org/mozilla-central/rev/b53faee9792e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P-][fixed-in-fx-team] → [Australis:P-]
Target Milestone: --- → mozilla31
Assignee | ||
Comment 18•10 years ago
|
||
Comment on attachment 8400123 [details] [diff] [review] Patch v6. r=mdeboer; s-r=bmcbride [Approval Request Comment] Bug caused by (feature/regressing bug #): Australis User impact if declined: Awkward rounded corners in add-on manager for Win 8 Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): Low, CSS only String or IDL/UUID changes made by this patch: None
Attachment #8400123 -
Flags: approval-mozilla-beta?
Attachment #8400123 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8400123 -
Flags: approval-mozilla-beta?
Attachment #8400123 -
Flags: approval-mozilla-beta+
Attachment #8400123 -
Flags: approval-mozilla-aurora?
Attachment #8400123 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Flags: needinfo?(mdeboer)
Keywords: checkin-needed
Comment 19•10 years ago
|
||
Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/f0c069af1f3a Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/cb7f81834560
Comment 20•10 years ago
|
||
Verified issue fixed on Windows 8.1 (32bit and 64bit architectures) using: - latest Firefox Nightly (build ID: 20140407030203) - latest Firefox Aurora (build ID: 20140407004002) - Firefox 29 beta 6 (build ID: 20140407135746).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment 21•10 years ago
|
||
Backed out on beta for causing bug 999080: https://hg.mozilla.org/releases/mozilla-beta/rev/02556a393ed8
Comment 22•10 years ago
|
||
Verified disabled on Fx 29 RC, build ID: 20140421221237.
You need to log in
before you can comment on or make changes to this bug.
Description
•