Closed Bug 980746 Opened 10 years ago Closed 10 years ago

UITour: Many browser-chrome tests leak 1 docshell when run alone

Categories

(Firefox :: General, defect)

29 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 992611

People

(Reporter: MattN, Assigned: MattN)

References

Details

(Keywords: memory-leak, Whiteboard: [Australis:P5])

Attachments

(1 file)

e.g. browser/modules/test/browser_UITour_annotation_size_attributes.js | leaked 1 docShell(s) until shutdown

It doesn't happen in all of them but does in most.
Blocks: 819963
At least one of the causes is speculative connections from the search bar (since we have a search target) that gets tested. See also bug 964369.

This is reproducible on OS X 10.9 too.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Patrick, let me know if you prefer my suggestion in bug 964369 comment 3 to disable speculative connections by default in the test suites?
Attachment #8402264 - Flags: review?(mcmanus)
Attachment #8402264 - Flags: review?(bmcbride)
Comment on attachment 8402264 [details] [diff] [review]
v.1 Disable speculative connections for the search bar

Review of attachment 8402264 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the code, but it's on the condition that this patch is only used if for some reason we can't use bug 992611 - because that's a far better solution, IMO.
Attachment #8402264 - Flags: review?(bmcbride) → review+
Also, nice catch :)
Comment on attachment 8402264 [details] [diff] [review]
v.1 Disable speculative connections for the search bar

Review of attachment 8402264 [details] [diff] [review]:
-----------------------------------------------------------------

agree that 992611 is the way to go
Attachment #8402264 - Flags: review?(mcmanus) → feedback-
Depends on: 992611
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: