Ryan VanderMeulen [:RyanVM] Reporter
	Description • 10 years ago

We're seeing this perma-leak across all platforms when we run mochitest-bc in chunks and devtools split into their own testsuite on Cedar. This is blocking our ability to enable these changes in production.

Andrew, any chance you could lend a hand investigating? Logs are available in any bc2 run shown here:
https://tbpl.mozilla.org/?tree=Cedar&jobname=mochitest.*chrome&rev=860811be1a5d

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 1 • 10 years ago

FWIW, it started on this push:
https://hg.mozilla.org/projects/cedar/rev/50dab12cadf1

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 2 • 10 years ago

Which basically agrees with "don't run devtools tests with the rest of mochitest-bc and get leaks"

	Andrew McCreight [:mccr8]
	Comment 3 • 10 years ago

Hmm.  Looks like networking stuff.

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 4 • 10 years ago

Oh, this is probably a dupe of bug 964369, except now it's a perma-leak.

	Matthew N. [:MattN] Assignee
	Comment 5 • 10 years ago

Can you test the patch in bug 964369 and see if it helps? Thanks

	Phil Ringnalda (:philor)
	Comment 6 • 10 years ago

https://tbpl.mozilla.org/?tree=Cedar&showall=1&rev=a670ee5f5860

	Matthew N. [:MattN] Assignee
	Comment 7 • 10 years ago

I found an xpcshell test for this API but prefs_general.js isn't used on xpcshell so I didn't need to modify it.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=d390d6041643

	Matthew N. [:MattN] Assignee
	Comment 8 • 10 years ago

Can you check if this fixes the leaks?

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 9 • 10 years ago

pushed to cedar, here is a view of bc2 (the leaking test):
https://tbpl.mozilla.org/?tree=Cedar&jobname=cedar%20debug%20test%20mochitest-browser-chrome-2&rev=16a531cb05bd

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 10 • 10 years ago

looks like the leak is gone:
https://tbpl.mozilla.org/?tree=Cedar&rev=16a531cb05bd

nice stuff.

	Patrick McManus [:mcmanus]
	Comment 11 • 10 years ago

Comment on attachment 8402279 [details] [diff] [review]
v.1 Set network.http.speculative-parallel-limit to 0 in non-xpcshell tests

Review of attachment 8402279 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with this. The test suite is not supposed to be making external connections and it certainly is doing so in the current state of things.

As comment 7 says, there is at least some coverage for Speculative Connections in xpcshell that is unaffected by at least this change.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 12 • 10 years ago

should I consider adding this to talos?

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 13 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/2f612effdfda

	Matthew N. [:MattN] Assignee
	Comment 14 • 10 years ago

(In reply to Joel Maher (:jmaher) from comment #12)
> should I consider adding this to talos?

It would probably be good to do since I believe TART can run with the New Tab Page showing (which also does speculative connections). If the mouse cursor happens to be over a tile, it could make a connection.

	Carsten Book [:Tomcat]
	Comment 15 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/2f612effdfda

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 16 • 10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/4fdcd09ca66d