Closed
Bug 981908
Opened 11 years ago
Closed 11 years ago
The separator between 'Bookmark this site' and 'Bookmark menu' shows a dark border at the beginning of the transition when hovering the 'Bookmark this Site' button
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jaws, Assigned: mconley)
References
Details
(Whiteboard: [Australis:P3])
Attachments
(1 file, 1 obsolete file)
(deleted),
application/x-shockwave-flash
|
Details |
A regression introduced by a patch in bug 960517. See attached SWF file for video of this happening.
I think there is a border-color of -moz-use-text-color that is getting applied at the beginning of the transition, but I haven't been able to find the exact spot.
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
The 2px border is also a bug.
I have also found another bug related to the bookmarks menu button : When you "drag" the bookmarks menu button, the separator will be missing.
Updated•11 years ago
|
Blocks: theme-win8
Updated•11 years ago
|
Whiteboard: [Australis:P4] → [Australis:P3]
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mconley
Assignee | ||
Comment 3•11 years ago
|
||
This was surprisingly difficult to debug, and I don't 100% understand it yet. Something about using -moz-border-end and the border-right-color-ltr-source being set to physical was causing this to happen. I really can't give a thorough explanation, I'm afraid. :/
What I am able to give, is a patch that fixes it.
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8394406 [details] [diff] [review]
Patch v1
*shrug*
Attachment #8394406 -
Flags: review?(jaws)
Comment 5•11 years ago
|
||
Does replacing -moz-border-end: none; with -moz-border-end-style: none; help?
If not, maybe you're running into bug 591600. Does it help if you replace 'transparent' with e.g. 'hsla(210,54%,20%,.0)' here: <http://hg.mozilla.org/mozilla-central/annotate/cf485c48b52f/browser/themes/windows/browser.css#l579>?
Comment 6•11 years ago
|
||
(In reply to Dão Gottwald [:dao] (on vacation from March 21 to 28) from comment #5)
> If not, maybe you're running into bug 591600. Does it help if you replace
> 'transparent' with e.g. 'hsla(210,54%,20%,.0)' here:
> <http://hg.mozilla.org/mozilla-central/annotate/cf485c48b52f/browser/themes/
> windows/browser.css#l579>?
Err, bug 591600 is about gradients, but may still be remotely related if the problem is how 'transparent' is handled.
Comment 7•11 years ago
|
||
Mike, did you try applying my patch in bug 984976 first? I mentioned in that bug that I didn't see this flickr with the style changes applied there.
Updated•11 years ago
|
Flags: needinfo?(mconley)
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 8•11 years ago
|
||
(FWIW, when I reviewed bug 984976, I also didn't see the issue anymore)
Assignee | ||
Comment 9•11 years ago
|
||
I like freebies. Testing patch for bug 984976 now.
Flags: needinfo?(mconley)
Assignee | ||
Comment 10•11 years ago
|
||
Woo! Bug 984976 takes care of it!
We're done here folks. Sayonara!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 8394406 [details] [diff] [review]
Patch v1
Review of attachment 8394406 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the following change.
::: browser/themes/windows/browser.css
@@ +638,5 @@
> + * Apparently, for -moz-border-end, even though there's no border here, we still
> + * need to have a colour assigned to it for when we're hovering the menu button,
> + * since we transition on the border colour.
> + */
> + -moz-border-end: none hsla(210,54%,20%,.2);
Please expand this to:
-moz-border-end-style: none;
-moz-border-end-color: hsla(210,54%,20%,.2);
Attachment #8394406 -
Flags: review?(jaws) → review+
Reporter | ||
Updated•11 years ago
|
Attachment #8394406 -
Flags: review+
Assignee | ||
Comment 12•11 years ago
|
||
Gah - sorry, should have removed the r? on that patch when I WORKSFORME'd this.
Assignee | ||
Updated•11 years ago
|
Attachment #8394406 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•