STR: 1. Make sure the Bookmarks toolbar is visible 1. Open Customize Mode on OSX nightly 2. Drag the Bookmarks toolbar placeholder button to the nav-bar Resulting issues that can be seen: 1. The toolbar height jumps to a smaller size when the placeholder is dragged out of it 2. When placed in the nav-bar, the placeholder causes all other toolbar items to be mis-aligned.

Wouldn't this be fixed by fixing bug 734326 ?

(In reply to Guillaume C. [:ge3k0s] from comment #1) > Wouldn't this be fixed by fixing bug 734326 ? No, the placeholder button already has different styling than bookmark items. The problem is that the button inside Customize Mode is misbehaving.

(In reply to Mike de Boer [:mikedeboer] from comment #0) > STR: > > 1. Make sure the Bookmarks toolbar is visible > 1. Open Customize Mode on OSX nightly > 2. Drag the Bookmarks toolbar placeholder button to the nav-bar > > Resulting issues that can be seen: > 1. The toolbar height jumps to a smaller size when the placeholder is > dragged out of it > 2. When placed in the nav-bar, the placeholder causes all other toolbar > items to be mis-aligned. (2) is filed separately already: bug 923156

The 19px change is simply reflecting reality - the bookmarks buttons in the navbar are already 18px with a 1px bottom border. The other min-height is new and fixes the issue at hand.

Comment on attachment 8406220 [details] [diff] [review] bookmarks toolbar shrinks when removing the bookmarks toolbar items, Review of attachment 8406220 [details] [diff] [review]: ----------------------------------------------------------------- This does fix the issue at hand. I'm still unhappy about the state we get in when you drag the Personal Toolbar Items on the nav-bar or TabsToolbar... but that has _nothing_ to do with this bug :) Most importantly, this patch doesn't regress it further.

remote: https://hg.mozilla.org/integration/fx-team/rev/57f2b31da569

Comment on attachment 8406220 [details] [diff] [review] bookmarks toolbar shrinks when removing the bookmarks toolbar items, [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a (existed pre-Australis, too) User impact if declined: toolbar changes size if you remove items off it Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low, CSS-only String or IDL/UUID changes made by this patch: none