Tim Nguyen :ntim Assignee
	Description • 11 years ago

      No description provided.

	Mike de Boer [:mikedeboer]
	Comment 1 • 10 years ago

Stanzilla, why did you n-i'd us? Anything specific you wanted to ask?

	Stanzilla
	Comment 2 • 10 years ago

Oh, sorry. that was a mistake :/(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Stanzilla, why did you n-i'd us? Anything specific you wanted to ask?

	Stanzilla
	Comment 3 • 10 years ago

I had a question but forgot what it was and somehow sent the comment, Sorry!

	Jared Wein [:jaws] (please needinfo? me)
	Comment 4 • 10 years ago

What does a new-tab icon for Windows 8 look like? I looked at IE11 and didn't see anything unique to Windows 8 there. Thanks!

	Tim Nguyen :ntim Assignee
	Comment 5 • 10 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> What does a new-tab icon for Windows 8 look like? I looked at IE11 and
> didn't see anything unique to Windows 8 there. Thanks!

http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html

They are flat icons, without the slight gradient in it.

	Tim Nguyen :ntim Assignee
	Comment 6 • 10 years ago

How did you make Toolbar.png specific to each Windows version ? I'd like to use the same technique for this bug. Thanks !

	Tim Nguyen :ntim Assignee
	Comment 7 • 10 years ago

(In reply to Tim Nguyen [:ntim] from comment #6)
> How did you make Toolbar.png specific to each Windows version ? I'd like to
> use the same technique for this bug. Thanks !

Nevermind, just figured it out.

	Tim Nguyen :ntim Assignee
	Comment 8 • 10 years ago

Can you provide assets here please ? Thanks :)

	Tim Nguyen :ntim Assignee
	Comment 11 • 10 years ago

Optimized.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 14 • 10 years ago

Tim, are you going to put up a patch here?

	Tim Nguyen :ntim Assignee
	Comment 15 • 10 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #14)
> Tim, are you going to put up a patch here?

Yes, I've made one, though, I noticed it introduces a contrast regression, which is why I haven't posted anything yet. I simply need to update the colors of the new graphics to a darker one first :)

	:Gijs (he/him)
	Comment 17 • 10 years ago

Comment on attachment 8496939 [details] [diff] [review]
Patch

Review of attachment 8496939 [details] [diff] [review]:
-----------------------------------------------------------------

If I understand correctly, you've moved the original png files to -XPVista7.png -- why aren't these reflected as hg moves in the patch?

::: browser/themes/windows/jar.mn
@@ +81,5 @@
>          skin/classic/browser/Toolbar.png                             (Toolbar-XP.png)
>          skin/classic/browser/Toolbar-inverted.png
>          skin/classic/browser/Toolbar-lunaSilver.png
>          skin/classic/browser/toolbarbutton-dropdown-arrow.png
> +        skin/classic/browser/toolbarbutton-dropdown-arrow-XPVista7.png

You can just use this file and have it be packaged as toolbarbutton-dropdown-arrow.png in the classic theme, can't you - the non-aero theme doesn't ever get used on Windows 8, I thought? That way we can avoid shipping the same files multiple times. See how this was done for the menuPanel.png images.

@@ +187,5 @@
>          skin/classic/browser/social/chat-icons.svg                   (../shared/social/chat-icons.svg)
>          skin/classic/browser/social/gear_default.png                 (../shared/social/gear_default.png)
>          skin/classic/browser/social/gear_clicked.png                 (../shared/social/gear_clicked.png)
>          skin/classic/browser/tabbrowser/newtab.png                   (tabbrowser/newtab.png)
> +        skin/classic/browser/tabbrowser/newtab-XPVista7.png          (tabbrowser/newtab-XPVista7.png)

Same here and for tab-arrow-left.

	Tim Nguyen :ntim Assignee
	Comment 18 • 10 years ago

Addresses review comments.

	:Gijs (he/him)
	Comment 19 • 10 years ago

Comment on attachment 8511976 [details] [diff] [review]
Patch v2

Why no update in the classic theme for toolbarbutton-dropdown-arrow.png - that should also use the XPVista7 thing, right?

But the r- is because you override *.png with *-XPVista7.png on osversion<6.2, which includes XP, where (non-aero) you don't package a file called *-XPVista7.png. You should override on 6.1 and 6.0 only.

	Tim Nguyen :ntim Assignee
	Comment 20 • 10 years ago

Addressed review comments

	Carsten Book [:Tomcat]
	Comment 21 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/c0e559c7fb5a

	Carsten Book [:Tomcat]
	Comment 22 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/c0e559c7fb5a