Closed
Bug 985393
Opened 10 years ago
Closed 10 years ago
Avoid loading icons the user can't see on homepage
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 898320
People
(Reporter: mat, Assigned: mat)
References
Details
(Keywords: perf)
When viewing the homepage on a small screen, only 3 featured apps are shown, you need to follow the "View All" link to see them all. However, looking at the network tab I see that we load the icons for all featured apps and not just those 3. We should do something similar than we did in bug 983346 to avoid loading those icons when they are hidden.
Assignee | ||
Comment 1•10 years ago
|
||
Actually, it looks like this also happens on a wide screen, if there are more than 7 apps.
Summary: Avoid loading icons the user can't see on mobile homepage → Avoid loading icons the user can't see on homepage
Comment 2•10 years ago
|
||
Good call!
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mpillard
Assignee | ||
Comment 3•10 years ago
|
||
https://github.com/mozilla/fireplace/pull/405
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
I do this here: https://github.com/mozilla/fireplace/pull/364
Assignee | ||
Comment 5•10 years ago
|
||
Yeah, that's certainly a better approach. If your pull request is going in prod this week then we can forget about mine, otherwise this might be good to have in the meantime.
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Updated•10 years ago
|
Blocks: marketplace-perf
You need to log in
before you can comment on or make changes to this bug.
Description
•