Bruce Huang [:bhuang] (inactive) Reporter
	Description • 10 years ago

As a user, I want the keyboard to be able to handle multiple touched keys at once, in order to increase typing speed.

Acceptance:
Press and hold on a letter, the hint on the letter should appear.
While pressing the first letter, tap and hold a second letter.  The first letter should be typed in the input field, while the second hint shows up.
Release both keys, the second letter should enters in the input field.

Refer to p.14 of UX spec in bug 983043

	Omega Feng [:Omega] [:馮於懋]
	Comment 1 • 10 years ago

See bug 983043 for the UX spec update.

	William Hsu [:whsu]
	Comment 2 • 10 years ago

Add the test cases.
- https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2640

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 3 • 10 years ago

Spec should be https://bug983043.bugzilla.mozilla.org/attachment.cgi?id=8435583#15

I can do this after bug 1025520.

	David Flanagan [:djf]
	Comment 4 • 10 years ago

I'm pretty sure that the keyboard does currently support multi-touch, at least if you're typing fast enough that the alternative character menus do not appear. This was fixed over a year ago. If it is broken now that is a regression.

It might be that the current implementation is based on the order the keys are released in, not the order they are pressed in.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 5 • 10 years ago

(In reply to David Flanagan [:djf] from comment #4)
> It might be that the current implementation is based on the order the keys
> are released in, not the order they are pressed in.

Yes, therefore my interpretation of this bug is to simply fix the behavior described above.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 6 • 10 years ago

Note to myself: talk to UX in person on the spec detail and compare behavior with other platforms.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 7 • 10 years ago

Also, need to figure out when the feedback should took place.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 8 • 10 years ago

Confirm with Omega offline on the desired behavior. He reaffirmed that UX would like to change the event process sequence stated. I think I can make this change on top of bug 1029356 and before bug 1035062, in ActiveTargetsManager.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 9 • 10 years ago

This is now ready for review although it's currently on top of bug 1029356.

The patch actually roll back the API implemented in bug 1029356 a bit because I was maintaining a one-to-one relation between presses and active targets, but that has to be broken with the new feature in this bug.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 10 • 10 years ago

Comment on attachment 8452100 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/21473

Hi Tim,

I did not see any change in apps/keyboard/js/keyboard/alternatives_char_menu_manager.js, but seems the interface of show() function has changed?

Other parts should be ok, but I just want to double confirm, so clear the review flag so I'll get notified.

Thanks.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 11 • 10 years ago

Comment on attachment 8452100 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/21473

It was lost, not sure why. Thanks for catching that.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 12 • 10 years ago

Comment on attachment 8452100 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/21473

Then, this looks good to me, r+.
Thank you.

	Tim Guan-tin Chien [:timdream] (please needinfo) Assignee
	Comment 13 • 10 years ago

master: https://github.com/mozilla-b2g/gaia/commit/27f64f0f415a6014c11a13d667d70b13365fe265

	Johan Lorenzo [:jlorenzo] - On PTO, back on September 11th
	Comment 14 • 10 years ago

I don't see why this issue concerns the Homescreen. Can you detail the reason Gerry?

	Gerry Chang [:gchang]
	Comment 15 • 10 years ago

Hi Johan,
This is a mis-typing error when updating QA Whiteboard. Change back to Gaia::Keyboard.

	Gerry Chang [:gchang]
	Comment 16 • 10 years ago

Verified @ 
Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1

and the test results is on
https://moztrap.mozilla.org/results/cases/?filter-run=5113