Closed Bug 988048 Opened 10 years ago Closed 6 years ago

Use Task.jsm in devtools framework

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bbenvie, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

devtools/framework has a lot of ugly Promise infected code. Let's clean it up.
Attached patch promise-framework.patch (obsolete) (deleted) — Splinter Review
Converts most functions that use Promises to be use Tasks. Various cleanup as well.

https://tbpl.mozilla.org/?tree=Try&rev=d46a3b7e9123
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Attached patch framework-cleanup.patch (deleted) — Splinter Review
That was the wrong patch file. Here it is.
Attachment #8396759 - Attachment is obsolete: true
Depends on: 887923
Waiting for bug 887923 (change Task.jsm to use Promise.jsm) to stick so as to not accidentally introduce any new dependencies on gross addon-sdk promises.
Assignee: bbenvie → nobody
Status: ASSIGNED → NEW
this and bug 1348530 should be closed WONTFIX, since it's better switching to async, in bug 1365607.
Product: Firefox → DevTools
Devtools has been moving away from this in bug 1365607 -> wontfix.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: