Closed
Bug 988229
Opened 11 years ago
Closed 11 years ago
Loop webapp should display proper notifications to end user
Categories
(Hello (Loop) :: Client, defect, P3)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: NiKo, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
Currently we rely on alert() to display error messages to end user, we should probably reuse the Backbone notification system introduced for the desktop client.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nperriault
|
|
Assignee | |
Comment 1•11 years ago
|
||
This is the first step of the patch, introducing a new shared Notifier component. Next step is to update desktop code to use it as well.
Attachment #8400618 -
Flags: review?(standard8)
|
||
Updated•11 years ago
|
|
|
Assignee | |
Comment 2•11 years ago
|
||
After having a long discussion with dmose about this, we should just use the current NotificationListView as a notifier. I'll revamp the patch accordingly.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8400618 -
Attachment is obsolete: true
Attachment #8400618 -
Flags: review?(standard8)
|
|
||
Updated•11 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 3•11 years ago
|
||
Updated patch for a shared notification system.
Attachment #8401171 -
Flags: review?(standard8)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8401171 -
Flags: review?(standard8) → review?(dmose)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8401171 [details]
https://github.com/mozilla/loop-client/pull/11
r=dmose, conditional on a few things described in the PR.
Attachment #8401171 -
Flags: review?(dmose) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•11 years ago
|
||
|
|
||
Comment 7•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Target Milestone: --- → mozilla33
Looks like this landed with tests. Does this need QA testing?
Whiteboard: [qa?]
We'll focus on testing the individual notifications. Untracking for QE verification.
Flags: qe-verify-
Whiteboard: [qa?]
You need to log in
before you can comment on or make changes to this bug.
Description
•