Closed
Bug 991126
Opened 11 years ago
Closed 11 years ago
Link Clicker UI: Pressing start multiple times causes multiple push requests
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla33
People
(Reporter: standard8, Unassigned)
References
Details
Attachments
(1 file)
STR:
1) Generate a link and open it in a tab or separate browser.
2) Click the start button multiple times (or double click, etc) before the call starts.
Expected results:
One conversation window is opened and the call starts.
Actual Results:
Multiple conversation windows are opened.
|
Reporter | |
Updated•11 years ago
|
Priority: -- → P2
|
Assignee | |
Updated•11 years ago
|
QA Contact: nperriault
|
|
Assignee | |
Comment 1•11 years ago
|
||
This patch prevent multiple submissions of the call start form. It depends on Bug 988229 which patch should land first.
Assignee: nobody → nperriault
Attachment #8401363 -
Flags: review?(dmose)
|
|
Assignee | |
Updated•11 years ago
|
QA Contact: nperriault
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8401363 [details]
https://github.com/mozilla/loop-client/pull/13
Giving this review to Standard8, since I took one of his.
It's not quite clear to me how to get github to generate the correct comparison so that the thing that needs reviewing doesn't include the stuff that's already been reviewed as part of bug 988299 (the current PR appears to include those changes).
Attachment #8401363 -
Flags: review?(dmose) → review?(standard8)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8401363 [details]
https://github.com/mozilla/loop-client/pull/13
r=Standard8. Please squash the commits before landing.
Attachment #8401363 -
Flags: review?(standard8) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Landed on master https://github.com/mozilla/loop-client/commit/ee5bd383f1694552e6211bb28e6bcdcb207fe822
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•11 years ago
|
||
|
|
Reporter | |
Comment 6•10 years ago
|
||
|
|
Reporter | |
Updated•10 years ago
|
Target Milestone: --- → mozilla33
It looks like this landed with tests. Does this need QA testing?
Whiteboard: [qa?]
Verified fixed through recent smoketesting.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Contact: anthony.s.hughes
Whiteboard: [qa?]
You need to log in
before you can comment on or make changes to this bug.
Description
•