:gerard-majax [PTO 01/08/2023-10/09/2023] Reporter
	Description • 10 years ago

With Gecko/Gaia from a couple of minutes ago, opening a SMS thread, logcat shows the following:

E/GeckoConsole( 1695): [JavaScript Error: "TypeError: this.lockScreenContainer is null" {file: "app://system.gaiamobile.org/js/notifications.js" line: 471}]

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 1 • 10 years ago

Caused by bug 937442. Looks like we will need to make sure the lockScreenContainer is not null when removing notifications, like we did for when adding notifications [1].

1.) https://github.com/mozilla-b2g/gaia/commit/9f21d2c750b4c642f77bd3bf638f0f2fea93fb08#diff-6

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 2 • 10 years ago

Greg, can you take a look at this?

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 3 • 10 years ago

Comment on attachment 8402546 [details]
Github PR

OK. The patch seems reasonable, so I give the review+.
It may still need Travis result to be landed.

	Michael Henretty [:mikehenrty][:mhenretty] Assignee
	Comment 4 • 10 years ago

Travis went green, merged to master: https://github.com/mozilla-b2g/gaia/commit/26d6c4162938e55c90433f73081d7901f11e1852

Thanks for the quick review Greg!