On Month and Day taps, we can start edit Event by double click. But only on week tap, it’s not working.

During the implementation of this feature we only did day and month view iirc. I don't remember the exact reasons that we didn't do the week view, but it should be possible.

Assigning this issue to Vishnu.

Yeah I think the UX was just unclear since the week view currently doesn't make it obvious which hour you'd be tapping on.

It is a new UI feature. We should let Harly know this.

Yes, since we have double tap to add new event in Month & Day view, it make sense to have double tap in Week view as well. However, it will be great to add some visual hint to the user when single tap on day/week view like what google calendar do. I will add this bug to the UX backlog.

Hi, Please review the patch for adding event from week view. This feature has been implemented using 'single tap' Since week view is using the prototype of day view, so single tap has been used to add event.

Comment on attachment 8414317 [details] [diff] [review] Patch for add event from week View Review of attachment 8414317 [details] [diff] [review]: ----------------------------------------------------------------- I believe Gareth did the original implementation of this feature for day/month views, so swapping the review over to him. The only thing I'd like to see here is the inclusion of some tests. It would be really good to have a marionette test for this I think.

Attached is a draft wireframe to get us started, feel free to provide any comments or feedbacks. Thanks

Assigning this bug to Swathi KS. Swathi KS will upload patch and follow this issue.

Hi Please provide the following information 1. what should be the default time while adding new event from month view. 2. will any new color codes will be provided for this UX feature or it will be same as previous.

(In reply to swathiks115 from comment #10) > Hi > > Please provide the following information > 1. what should be the default time while adding new event from month view. Today: Set default time as the next hour compare to current time, ex: if current time is 9:42am, then set time from 10:00am to 11:00am Other days: Set default time from 9:00am to 10:00am > 2. will any new color codes will be provided for this UX feature or it will > be same as previous. Don't know what color codes are you referring to?

Hi, Please review the patch for adding event on double tap. This is implemented as per wireframe attached. Double tapping on day in month will go to add event page. In day and week, on tap visual hint will appear. Tapping on visual hint will go to add event page.

(In reply to swathiks115 from comment #12) > Created attachment 8420047 [details] [diff] [review] > Double click to add event.patch > > Hi, > > Please review the patch for adding event on double tap. > > This is implemented as per wireframe attached. > > Double tapping on day in month will go to add event page. > In day and week, on tap visual hint will appear. Tapping on visual hint will > go to add event page. Nice work, I have some feedbacks from UX side: 1. Double tapping in month view will trigger the value selector in add new event page. 2. The visual hint in day view will cover the time on the left, it is different from the wireframe, as it should be displayed like regular event width. 3. This wasn't defined in the wireframe, but I think the visual hint should disappear when user select an exist event or switch to other views. Thanks

Hi, Please review the patch. This patch is updated with following UX changes 1. Double tapping in month view go to add new event page and it will not trigger value selector in add new event page. 2. The visual hint in day view is displayed as in wireframe. 3. Visual hint will disappear if user selects other view or saved event.

Hi Swathiks, Welcome to the project! Would you mind sending a pull request on GH instead of posting a patch here? See our guidelines for contributing here https://github.com/mozilla-b2g/gaia/blob/master/CONTRIBUTING.md. Thanks!

The PR is raised with modifications as per the comment #13. Please review it.

Hi Swathiks, What I've seen from the patch, everything is working except that the visual hint still won't disappear when user select an exist event or switch to other views.

(In reply to Harly Hsu from comment #17) > Hi Swathiks, > What I've seen from the patch, everything is working except that the visual > hint still won't disappear when user select an exist event or switch to > other views. I have rebased the code as per your comment. Please check.

Looks good to me, thanks Swathiks for the great work!!

BTW, the new 5-day week view uses a totally different structure so this patch can't really be used... sorry about that.

we landed the 5-day week view into master just now. I implemented a basic "double tap" behavior without any visual feedback (like the current day/month views). We should probably wait until the Day View uses the same logic (Bug 1052960) before we decide to implement this feature (to avoid duplication and extra work).

marking it as a duplicate of Bug 999959 since I already have a working patch there that works for both views (week and month).