Closed Bug 999959 Opened 11 years ago Closed 10 years ago

Double clicking to add an event in day and week views.

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(tracking-b2g:+)

VERIFIED FIXED
2.1 S7 (24Oct)
tracking-b2g +

People

(Reporter: evanxd, Assigned: mmedeiros)

References

Details

(Whiteboard: [priority])

Attachments

(2 files, 1 obsolete file)

For the consistence of UI design in month view, we should change the UI design of day view as double clicking to add an event. Currently we could do one clicking to add an event.
Hi Harly, We should fix this. Could you give the clear UI spec here? We could just fix it by the double click design in day view, or you have other idea? Thanks.
Flags: needinfo?(hhsu)
Attached file [Calendar] Double Click to Add Event_Draft.pdf (obsolete) (deleted) —
Attached is a draft wireframe to get us started, feel free to provide any comments or feedbacks. Thanks
Flags: needinfo?(hhsu)
blocking-b2g: --- → backlog
Whiteboard: [priority]
Assignee: nobody → evanxd
Assignee: evanxd → nobody
Attachment #8410874 - Attachment is obsolete: true
I implemented a basic double click for the week view (without visual feedback) and we have plans to change the day view to use the same logic, so listing the bugs as dependencies.
Depends on: 1052960, 992728
Blocks: 1009249
[priority] --> tracking-b2g:+ conversion
tracking-b2g: --- → +
Assignee: nobody → mmedeiros
Target Milestone: --- → 2.1 S7 (24Oct)
Hi Harly, this is work in progress. I still plan to add some sort of "fade in" and "fade out" when the add event button appears/disappears, but just want to confirm if that is the expected behavior. Thanks! PS: the patch also adds same behavior to the week view.
Attachment #8505890 - Flags: ui-review?(hhsu)
one thing I forgot to say is that I made the "add event link" to hide automatically after 5 seconds. But not sure if that still makes sense, specially since I added the logic to hide it when clicking another time slot or panning the view. let me know what you think.
No longer depends on: 992728
Comment on attachment 8505890 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198 Thank you Miller, I don't think auto hide after 5 seconds is really needed here, since user can tap at other time slot or scroll to dismiss the "add event link". Other than that, this patch looks great! Good work!
Attachment #8505890 - Flags: ui-review?(hhsu) → ui-review+
Summary: Double clicking to add an event in day view. → Double clicking to add an event in day and week views.
Comment on attachment 8505890 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198 I updated the patch (removed the 5s autohide), cleaned the code, squashed the commits and wrote/updated marionette tests. Ready for review.
Attachment #8505890 - Flags: review?(gaye)
Comment on attachment 8505890 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25198 Looks awesome. Nice work!
Attachment #8505890 - Flags: review?(gaye) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hi Team, When I double click to add event on mouth view which it cannot go to add new event page. It is not match page 5.of SPEC. Could you please double confirm again. [Environment] Gaia-Rev 0dfc1996eb583c8b507a82bf6b8319624bba23ea Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/80e18ff7c7b2 Build-ID 20141029160202 Version 36.0a1 Device-Name flame FW-Release 4.4.2 FW-Incremental 39 FW-Date Thu Oct 16 18:19:14 CST 2014 Bootloader L1TC00011880
Edward, this bug only affected the Week and Day views, we have another bug for Month View (see Bug 1037351)
Status: RESOLVED → VERIFIED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: