Closed
Bug 994248
Opened 11 years ago
Closed 9 years ago
[tracking] Update Yahoo to use SSL (searchplugins, handlers), implement suggestions (all) and add resultdomain (desktop)
Categories
(Mozilla Localizations :: Other, defect)
Mozilla Localizations
Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: flod)
References
Details
Localized versions of Yahoo should use https (en-US was updated in bug 958883).
We should also be able to use suggestions.
http://hg.mozilla.org/mozilla-central/rev/97f2e9782e1c
Example:
http://ff.search.yahoo.com/gossip?output=fxjson&command=test
Also worth adding resultdomain as part of bug 991543
Comment 1•11 years ago
|
||
We should also remove any/all top2 conditionals to match bug 983723
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #0)
> Example:
> http://ff.search.yahoo.com/gossip?output=fxjson&command=test
Wrong example, right one
https://it.search.yahoo.com/sugg/ff?output=fxjson&appid=ffm&command=test
Comment 3•11 years ago
|
||
In addition: mobile should be ffm, desktop should be ffd
Assignee | ||
Comment 4•11 years ago
|
||
"id" has already been fixed as part of bug 521995.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/id/rev/6758bb3a92ae
Assignee | ||
Updated•11 years ago
|
Component: Infrastructure → Other
Assignee | ||
Comment 5•11 years ago
|
||
Mexican mobile fixed as part of bug 979256.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/6d84a4c6ea76
Assignee | ||
Comment 6•11 years ago
|
||
I see now that bug 958883 has now approval requests for aurora and beta. At this point in the cycle, and with Australis in the middle, I can only target Firefox 31 (so next cycle on aurora) for this update.
Comment 7•11 years ago
|
||
That's fine, people asked about it so I'm accelerating things where it's not a giant pain. :)
Assignee | ||
Comment 8•11 years ago
|
||
Good, I'll send a message to dev-l10n before this cycle ends to warn localizers about this change.
Current list of locales with a localized version of Yahoo
Desktop
an, as, ast, bn-IN, br, cy, de, en-GB, es-AR, es-CL, es-ES, es-MX, ff, fi, fr, fy-NL, ga-IE, gd, gl, gu-IN, hi-IN, id, it, ja, ja-JP-mac, kn, lij, mai, mr, nb-NO, oc, or, pa-IN, pt-BR, rm, son, sv-SE, ta, te, zh-TW
Mobile
de, en-GB, es-ES, fi, fr, ja, ja-JP-mac, pt-BR
(es-MX, id already fixed)
Assignee | ||
Comment 9•11 years ago
|
||
About the suggestion URL: any idea if there is one for Japan? I tried a few variations but could find anything.
Comment 10•11 years ago
|
||
Japan is weird, I don't think they even support SSL at present. Can you open a bug on that as an outlier, and we'll track it separately from the rest of the world?
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Mike Connor [:mconnor] from comment #10)
> Japan is weird, I don't think they even support SSL at present. Can you
> open a bug on that as an outlier, and we'll track it separately from the
> rest of the world?
Filed bug 997215
Assignee | ||
Comment 12•11 years ago
|
||
Waiting for confirmation, but apparently the fix was broken (bug 997402), another piece to fix.
Assignee | ||
Comment 13•11 years ago
|
||
Mike, some more questions.
1) zh-TW has a completely different search URL
http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/a74242573f4b/browser/searchplugins/yahoo-zh-TW.xml
Should it switch to the standard one?
2) Comment above (bug 997402). That involves only mobile, correct?
3) I see you didn't update Metro searchplugins for Yahoo, I guess I should do the same.
Flags: needinfo?(mconnor)
Comment 14•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #13)
> Mike, some more questions.
>
> 1) zh-TW has a completely different search URL
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/a74242573f4b/
> browser/searchplugins/yahoo-zh-TW.xml
>
> Should it switch to the standard one?
Yes.
> 2) Comment above (bug 997402). That involves only mobile, correct?
Yes, mobile-only.
> 3) I see you didn't update Metro searchplugins for Yahoo, I guess I should
> do the same.
No point, it's on the shelf, likely permanently.
Flags: needinfo?(mconnor)
Assignee | ||
Updated•11 years ago
|
Summary: [tracking] Update Yahoo to use SSL, implement suggestions and add resultdomain → [tracking] Update Yahoo to use SSL (searchplugins, handlers), implement suggestions (all) and add resultdomain (desktop)
Assignee | ||
Comment 15•11 years ago
|
||
One more change for mobile: bug 1001566.
Assignee | ||
Comment 16•11 years ago
|
||
Note: I'll report only the aurora changeset, but all changes will be ported to l10n-central as well if the repo is available (merge, or transplant where merge fails).
ach: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ach/rev/283872bec886
af: http://hg.mozilla.org/releases/l10n/mozilla-aurora/af/rev/c1da7644fd3c
ak: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ak/rev/cd03dd65044c
an:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/8e58750ea876
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/d1b78c06a54b
ar: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/bfcd8c063271
as: missed localized Yahoo in the first round
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/987adec41665
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/010c3299ba23
ast: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ast/rev/a4c330f86e9c
az: http://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/0639ac5787c2
be: http://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/d1dd96ca208c
bg: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bg/rev/b9b26b22d817
bn-BD: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-BD/rev/9d2416245872
bn-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/afe81d4e6aaf
br: missed differences in name/description for yahoo-france
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/cb2ab88368de
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/ae7204b8b676
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/82a104aae584
bs: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bs/rev/fc07e8ac02b9
ca: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/26ca90a6f529
cs: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a14d1ca7b718
csb: http://hg.mozilla.org/releases/l10n/mozilla-aurora/csb/rev/a2b7746763fc
cy: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/30199273bbfb
Assignee | ||
Comment 17•11 years ago
|
||
da: http://hg.mozilla.org/releases/l10n/mozilla-aurora/da/rev/821eb3fb3d40
de: http://hg.mozilla.org/releases/l10n/mozilla-aurora/de/rev/aab9b52d4ae0
el: http://hg.mozilla.org/releases/l10n/mozilla-aurora/el/rev/7602893249bc
en-GB: http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/7ce3542e29ea
en-ZA: http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-ZA/rev/5a384d35b6be
eo: http://hg.mozilla.org/releases/l10n/mozilla-aurora/eo/rev/0d627ebfc5de
es-AR: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/cc27b1a6f613
es-CL: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-CL/rev/6b8075459f1d
es-MX: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/94cf8101d558
et: http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/rev/efb967524047
eu: http://hg.mozilla.org/releases/l10n/mozilla-aurora/eu/rev/e7b11d771c44
Assignee | ||
Comment 18•11 years ago
|
||
fa: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/d323e39a090d
ff: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ff/rev/5806d5dc031a
fi: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/5421393966c5
fr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/7d271a1ccd68
fy-NL: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/bb5320119cc4
Assignee | ||
Comment 19•11 years ago
|
||
ga-IE: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/dce7702d2d33
gd: http://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/cc77f00d8674
gl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/gl/rev/fa89f328f595
gu-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/gu-IN/rev/d4c4749a4dfe
he: http://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/013af8da4ccb
hi-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/hi-IN/rev/2f036bba0095
hr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/hr/rev/9802eb9653a7
hsb: http://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/rev/a1c72b1fdcdf
hu: http://hg.mozilla.org/releases/l10n/mozilla-aurora/hu/rev/9967a955b6b6
hy-AM: http://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM/rev/751e7f4612f9
id: http://hg.mozilla.org/releases/l10n/mozilla-aurora/id/rev/6fdb72d49e1f
is: http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/11e89b3d3217
it: http://hg.mozilla.org/releases/l10n/mozilla-aurora/it/rev/5b7d43ea4957
Assignee | ||
Comment 20•11 years ago
|
||
ka: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/rev/963a4a468fc9
kk: http://hg.mozilla.org/releases/l10n/mozilla-aurora/kk/rev/a8540886bedb
km: http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/8b95fa1cc865
kn: http://hg.mozilla.org/releases/l10n/mozilla-aurora/kn/rev/7088f4003056
ko: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/rev/ea815877849d
ku: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ku/rev/f7afc216cbd8
Assignee | ||
Comment 21•11 years ago
|
||
lg: http://hg.mozilla.org/releases/l10n/mozilla-aurora/lg/rev/d15ca21704bd
lij: http://hg.mozilla.org/releases/l10n/mozilla-aurora/lij/rev/db3174a712cf
lt: http://hg.mozilla.org/releases/l10n/mozilla-aurora/lt/rev/c415dc65dff4
lv: http://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/rev/a18263225a77
mai: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/778bc3f1ebe7
mk: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mk/rev/5d04e281347e
ml: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ml/rev/ade4a186ebf1
mn: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mn/rev/efb5f448db18
mr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/5fb0cca00dd6
ms: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ms/rev/dfc5ae597b0e
my: http://hg.mozilla.org/releases/l10n/mozilla-aurora/my/rev/9a578d4773cd
nb-NO: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nb-NO/rev/20f0faf34f68
ne-NP: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ne-NP/rev/7c3f8e9f7556
nl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/rev/a7e16a8b0604
nn-NO: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nn-NO/rev/8ec571785dc6
nso: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nso/rev/7139f4e63191
Assignee | ||
Comment 22•11 years ago
|
||
oc: http://hg.mozilla.org/releases/l10n/mozilla-aurora/oc/rev/074b4eed21e5
or: http://hg.mozilla.org/releases/l10n/mozilla-aurora/or/rev/134406eb72bd
pa-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pa-IN/rev/8e50112a6542
pl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/36a26d5d25ea
pt-BR: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-BR/rev/15ab28104eaf
pt-PT: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-PT/rev/dfb3a21b8811
rm: http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/9349d0947e52
ro: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/6503133df05d
rw: http://hg.mozilla.org/releases/l10n/mozilla-aurora/rw/rev/54b68281f731
sah: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sah/rev/5d3993ed3248
si: http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/rev/0b1af908142a
sk: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sk/rev/cbf217db49d4
sl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sl/rev/acfccb46767b
son: http://hg.mozilla.org/releases/l10n/mozilla-aurora/son/rev/406add7c6ca8
sq: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/9b7b27b8fa32
sr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sr/rev/11dea333d7ea
sv-SE: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sv-SE/rev/6cb07611a17c
sw: http://hg.mozilla.org/releases/l10n/mozilla-aurora/sw/rev/053c9a9b26b0
Assignee | ||
Comment 23•11 years ago
|
||
ta: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ta/rev/04e4dfc8448f
ta-LK: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ta-LK/rev/c661f3a6106f
te: http://hg.mozilla.org/releases/l10n/mozilla-aurora/te/rev/130ea0bbffd1
th: http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/1b7581f5d8f0
ur: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ur/rev/7011860bba6a
vi: http://hg.mozilla.org/releases/l10n/mozilla-aurora/vi/rev/29fda48b0aad
wo: http://hg.mozilla.org/releases/l10n/mozilla-aurora/wo/rev/967942f2c3eb
xh: http://hg.mozilla.org/releases/l10n/mozilla-aurora/wo/rev/967942f2c3eb
zh-CN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-CN/rev/54ef420ad5d5
zh-TW: http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/154b1d126ec5
zu: http://hg.mozilla.org/releases/l10n/mozilla-aurora/zu/rev/0de147f3023f
I'll run more checks later to see if I missed anything.
Assignee | ||
Comment 24•11 years ago
|
||
A few missed locales, plus a fix for vi
es-ES: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/1853986637df
tn: http://hg.mozilla.org/releases/l10n/mozilla-aurora/tn/rev/e5ac80d2b76a
tr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/3ca8512f63a8
vi: http://hg.mozilla.org/releases/l10n/mozilla-aurora/vi/rev/d8112b321e87
@mconnor
Can you tell me something about Yahoo Bid and Yahoo Answer for zh-TW? They should come from bug 418273
http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/154b1d126ec5/browser/searchplugins
Yahoo Answer has a very weird URL (updated in bug 445093)
http://tw.rd.yahoo.com/referurl/knowledge/fp/header/search_button/*http://tw.knowledge.yahoo.com/search/search_result
Yahoo Bid
https://tw.search.bid.yahoo.com/
I translated the page online and it seems gone. CCing also Peter who may have more information on that page.
Flags: needinfo?(mconnor)
Comment 25•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #24)
> @mconnor
> Can you tell me something about Yahoo Bid and Yahoo Answer for zh-TW? They
> should come from bug 418273
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/154b1d126ec5/
> browser/searchplugins
>
> Yahoo Answer has a very weird URL (updated in bug 445093)
> http://tw.rd.yahoo.com/referurl/knowledge/fp/header/search_button/*http://tw.
> knowledge.yahoo.com/search/search_result
>
> Yahoo Bid
> https://tw.search.bid.yahoo.com/
> I translated the page online and it seems gone. CCing also Peter who may
> have more information on that page.
That searchplugins are older than I joined. Let me ask former locale owners.
For Yahoo! Bid, the search URL looks still working, e.g., https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid TW is https://tw.bid.yahoo.com/ though.
Assignee | ||
Comment 26•11 years ago
|
||
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #25)
> For Yahoo! Bid, the search URL looks still working, e.g.,
> https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid
> TW is https://tw.bid.yahoo.com/ though.
Right, I tested https://tw.search.bid.yahoo.com/search/ac and got a blank page, then the message on the root.
In this case I think it's safe to switch it the template to https (https://tw.search.bid.yahoo.com/search/ac) but the searchform should probably be https://tw.search.bid.yahoo.com (currently http://tw.search.bid.yahoo.com/search/ac)
Comment 27•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #26)
> (In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #25)
> > For Yahoo! Bid, the search URL looks still working, e.g.,
> > https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid
> > TW is https://tw.bid.yahoo.com/ though.
>
> Right, I tested https://tw.search.bid.yahoo.com/search/ac and got a blank
> page, then the message on the root.
>
> In this case I think it's safe to switch it the template to https
> (https://tw.search.bid.yahoo.com/search/ac) but the searchform should
> probably be https://tw.search.bid.yahoo.com (currently
> http://tw.search.bid.yahoo.com/search/ac)
The texts shown on https://tw.search.bid.yahoo.com/ says it's a 404 page, would it be strange that a 404 page is search form?
I couldn't find the original search form, only got the search box on the homepage (https://tw.bid.yahoo.com/) or advanced search (https://tw.bid.yahoo.com/tw/show/searchoptions)
Assignee | ||
Comment 28•11 years ago
|
||
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #27)
> The texts shown on https://tw.search.bid.yahoo.com/ says it's a 404 page,
> would it be strange that a 404 page is search form?
Not sure how much we actually use that value, but an error page is definitely not good.
In comment 26, what I meant to write was: searchform should be https://tw.bid.yahoo.com/ (i.e. the working URL).
Assignee | ||
Comment 29•11 years ago
|
||
Based on my scripts, I only need to fix zh-TW remaining searchplugins and Japanese in the separate bug.
http://l10n.mozilla-community.org/~flod/p12n/bug994248_ssl/
Filing another bug for fy-NL (search.order).
Comment 30•10 years ago
|
||
I assume we're done here now?
Assignee | ||
Comment 31•10 years ago
|
||
See comment 24 for zh-TW (Yahoo properties). If we don't need to fix those, we're done (the Japanese bug will remain open).
Assignee | ||
Comment 32•9 years ago
|
||
Considering this one fixed, as said Japanese will remain open.
I guess other searchplugins will be considered in a wider check for SSL at some point, if we decide to enforce that.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(mconnor)
Resolution: --- → FIXED
Comment 33•9 years ago
|
||
Verified fixed on Windows 7 64bit using latest Nightly 44.0a1 (buildID: 20151007030205) on the following localizations: ar, ast, de, en-GB, eo, es, es-CL, es-ES, es-MX, fa, fr, fy-ML, gl, he, id, it, lv, pt-BR, th, zh-TW.
You need to log in
before you can comment on or make changes to this bug.
Description
•