Closed
Bug 997402
Opened 11 years ago
Closed 11 years ago
both bing and yahoo params are broken
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox29 fixed, firefox30 fixed, firefox31 fixed)
RESOLVED
FIXED
Firefox 31
People
(Reporter: mconnor, Assigned: mconnor)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Found in testing inbound builds.
MozParam, despite the name, is not quite like Param. It works only if there's a condition attached, otherwise it's ignored (silently). I'm going to file a followup on the search service to warn somewhat noisily when that happens, but in the meantime this is now broken across branches. Automated testing bugs getting filed today or tomorrow so we don't regress this again, but I'll manually test ASAP.
That sound you hear is me quietly whacking my head on the desk.
Attachment #8407802 -
Flags: review?(mark.finkle)
Comment 1•11 years ago
|
||
Comment on attachment 8407802 [details] [diff] [review]
paramNotMozParam
I found bug 351817 was where we added MozParam. Too bad it doesn't have a fallback, but know I know.
Attachment #8407802 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8407802 [details] [diff] [review]
paramNotMozParam
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 984530
User impact if declined: no tags on searches, Mozilla loses money
Testing completed (on m-c, etc.): manual
Risk to taking this patch (and alternatives if risky): very tiny
String or IDL/UUID changes made by this patch: none
Attachment #8407802 -
Flags: approval-mozilla-beta?
Attachment #8407802 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8407802 -
Flags: approval-mozilla-beta?
Attachment #8407802 -
Flags: approval-mozilla-beta+
Attachment #8407802 -
Flags: approval-mozilla-aurora?
Attachment #8407802 -
Flags: approval-mozilla-aurora+
Comment 3•11 years ago
|
||
Mike pushed this to inbound and Aurora, but not beta.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae057f9c301b
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bc0fe512ffd
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/6bc0291bbe83
Oops, thought I pushed this to beta as well.
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Comment 6•11 years ago
|
||
I can't hear the sound because I'm violently banging my head against the wall...
I guess this has just become part of bug 994248.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•