Closed
Bug 1037670
Opened 10 years ago
Closed 9 years ago
pushing data with unexpected option_collection values can cause the resultset endpoint to return no data.
Categories
(Tree Management :: Treeherder: API, defect, P3)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1097090
People
(Reporter: camd, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
This causes the repo to basically be unusable, because no data whatsoever will show.
We should be able to skip jobs with bad values and still show the rest.
Reporter | ||
Comment 1•10 years ago
|
||
on resultset.py: 175 we may use a try/catch and if the option collection hash isn't found, then add the jobs grouped in that platform to an "error" section we return with the resultsets. This would allow the dev submitting data to look at the endpoint result and see why his jobs aren't showing.
or we could just log it. but either way, we need to just remove the jobs.
It may just be a good idea to have a try-catch block inside each of the for loops.
Updated•10 years ago
|
Blocks: treeherder-sheriff-transition, 1042077
Priority: -- → P1
Updated•10 years ago
|
Comment 3•10 years ago
|
||
Going to take an initial crack at this since I keep managing to break stuff by omitting collections.
Assignee: nobody → jlal
Comment 4•10 years ago
|
||
bandaid patch seems like UI copes with this just fine too.
Attachment #8549966 -
Flags: feedback?(mdoglio)
Comment 5•10 years ago
|
||
Comment on attachment 8549966 [details]
https://github.com/mozilla/treeherder-service/pull/332
I didn't forget about this, I'm just waiting for bug 1097090 to land on master to verify this is not needed :-)
Comment 6•10 years ago
|
||
This *should* be solved on latest master
Updated•10 years ago
|
Priority: P2 → P3
Comment 7•10 years ago
|
||
Comment on attachment 8549966 [details]
https://github.com/mozilla/treeherder-service/pull/332
Now that bug bug 1097090 is solved, we can drop the changes to treeherder/webapp/api/resultset.py
The changes to treeherder/webapp/api/utils.py are still useful, I'm happy to merge them :-)
Can you please update/rebase your PR accordingly?
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8549966 -
Flags: feedback?(mdoglio)
Updated•9 years ago
|
Assignee: jlal → nobody
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•