Closed Bug 1043328 Opened 10 years ago Closed 10 years ago

Submitting option_collection without opts can break future job insertion

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1037670

People

(Reporter: emorley, Unassigned)

References

Details

Migrated from: https://github.com/mozilla/treeherder-service/issues/112 lightsofapollo commented on 26 Feb: { When submitting jobs without option_collection.opts I noticed some errors like this: Traceback (most recent call last): File "/home/vagrant/treeherder-service/treeherder/webapp/api/views.py", line 126, in use_jobs_model return model_func(*args, jm=jm, **kwargs) File "/home/vagrant/treeherder-service/treeherder/webapp/api/views.py", line 332, in list job["option_collection_hash"]]['opt'] KeyError: u'da39a3ee5e6b4b0d3255bfef95601890afd80709 With the following job collection [{ "revision_hash": "...", "job": { "build_platform": { "platform": "2.2", "os_name": "android", "architecture": "ARMv7", "vm": false }, "job_guid": '11111', "name": "Testing gaia", "reason": "scheduler", "job_symbol": "?", "submit_timestamp": 1387221298, "start_timestamp": 1387221345, "end_timestamp": 1387222817, "state": "pending", "log_references": [], "option_collection": { } }] Looks like this is caused by this: https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/api/views.py#L325 which always seems to expect .opt } lightsofapollo commented on 26 Feb: { As long as I submit with option_collection = { opt: true } I don't run into this error. } jeads commented on 27 Feb: { Good catch! That's a bug, will add handling for an empty option_collection, it should definitely not be required. } geoelectric commented 23 days ago: { Ran into this too. camd helped me debug but was pretty mysterious. }
Yeah, Geo ran into this, too.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.