Closed
Bug 1059286
Opened 10 years ago
Closed 10 years ago
The "Similar Jobs" tab should be lazy loaded to improve performance
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: mdoglio)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
After treeherder has been open for only 30 mins or so, when switching back to it and trying to interact with the UI (eg open the repos menu) the entire browser becomes unresponsive for 5+ seconds, with the spinner appearing.
Sorry I don't have precise STR other than "open treeherder, switch to another repo, leave browser open".
Reporter | ||
Comment 1•10 years ago
|
||
Demoting this until we have better STR / the frequency with which this occurs becomes clear.
Priority: P1 → P2
Comment 2•10 years ago
|
||
Here's some resources on tracking down problems like this with Chrome: http://stackoverflow.com/questions/19621074/finding-javascript-memory-leaks-with-chrome
I'm not sure if Firefox devtools has anything that could help here too?
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8489446 -
Flags: review?(jeads)
Attachment #8489446 -
Flags: feedback?(cdawson)
Assignee | ||
Comment 4•10 years ago
|
||
The attached PR makes the bottom panel lazy load the similar jobs data and removes a few $scope.$watch calls.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8489446 -
Flags: review?(jeads) → review+
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/ed738080ce45fbbf8b541f3e119fce439d5f39a8
Bug 1059286 (partially) - lazy load the similar jobs
https://github.com/mozilla/treeherder-ui/commit/8fdae0a0e65e13fb397e44db21df88d8d2e10bf4
Merge pull request #180 from mozilla/bug-1059286-reduce-memory-consumption-bottom-panel
Bug 1059286 (partially) - lazy load the similar jobs
Reporter | ||
Comment 6•10 years ago
|
||
Morphing this bug to be about the patch that landed, since it's going to get confusing when we have multiple different issues under this given the regression patch I'm going to mark blocking this shortly.
Summary: UI janks/locks up periodically → The "Similar Jobs" tab should be lazy loaded to improve performance
Reporter | ||
Comment 7•10 years ago
|
||
Marking this as fixed - we can handle the regression in the new bug I'm about to file.
No longer blocks: treeherder-dev-transition
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Attachment #8489446 -
Flags: feedback?(cdawson) → feedback+
Comment 9•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/033f4d28123a6c45c78cb15b028240c08e8bb525
Bug 1059286 (partially) - lazy load the similar jobs
https://github.com/mozilla/treeherder/commit/e74ba9e735c976dee8fe0ff6c157d13fe0f94d01
Merge pull request #180 from mozilla/bug-1059286-reduce-memory-consumption-bottom-panel
Bug 1059286 (partially) - lazy load the similar jobs
You need to log in
before you can comment on or make changes to this bug.
Description
•