David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Description • 9 years ago

Even if events aren't processed by APZ, we still need to fix their reference point to account for any async transforms.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 1 • 9 years ago

Add the DispatchInputEvent call which will make sure the event goes through APZ first.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 3 • 9 years ago

This cleans up the Dispatch*Event functions in nsWindow so they take the actual type they're supposed to. Predictably there were paths with bad casts.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 4 • 9 years ago

Ensure that anything dispatching a WidgetInputEvent routes through DispatchInputEvent, which applies an APZ transform if one exists.

After the cleanup these are the only places (I think) that dispatch a WidgetInputEvent.

	Jim Mathies [:jimm]
	Comment 5 • 9 years ago

Comment on attachment 8577913 [details] [diff] [review]
part 3, clean up nsWindow dispatch

Review of attachment 8577913 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/MetroWidget.cpp
@@ +667,1 @@
>    mEventQueue.Push(newEvent);

mEventQueue.Push(cmdEvent);

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 6 • 9 years ago

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5e93ac53e79c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d47ee5553045
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/311dd54d806b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1727096f4b48

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/5e93ac53e79c
https://hg.mozilla.org/mozilla-central/rev/d47ee5553045
https://hg.mozilla.org/mozilla-central/rev/311dd54d806b
https://hg.mozilla.org/mozilla-central/rev/1727096f4b48

	Gary [:streetwolf52]
	Comment 8 • 9 years ago

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1144081 for a possible regression due to this patch.

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/d45aaa6d2217

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/4510d4116527