Closed
Bug 1144827
Opened 10 years ago
Closed 10 years ago
Right mouse button click doesn't work properly when selecting items from mouse menu
Categories
(Core :: Widget: Win32, defect)
Tracking
()
VERIFIED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox39 | + | verified |
People
(Reporter: Virtual, Assigned: dvander)
References
Details
(Keywords: nightly-community, regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Right click mouse button on some site in non specific space to show up a menu.
2. Select for example "Bookmark This Page" with right click.
3. Nothing will happen.
It's probably a similar regression from bug #1143567, like in was bug #1144081.
[Tracking Requested - why for this release]: Regression
@ David Anderson [:dvander] - Could you look on this issue?
Flags: needinfo?(dvander)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•10 years ago
|
Keywords: regression
Updated•10 years ago
|
Component: Toolbars and Customization → Widget: Win32
Product: Firefox → Core
Comment 2•10 years ago
|
||
Right-click on 'forward/back' arrow does not produce the history list. No errors in Browser Console.
Comment hidden (typo) |
Comment 4•10 years ago
|
||
Oops, I posted wrong bug
Please ignore comment #3
Updated•10 years ago
|
Attachment #8579718 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Also happens on my ASUS x64 laptop, no special kbd, etc.
Comment 6•10 years ago
|
||
I don't think the expression describes all the situation. On my computer, now I can left click on bookmark menu, but if I want to right click on a special bookmark to let a context menu show on it nothing happens.
Comment 7•10 years ago
|
||
(In reply to leichixian from comment #6)
> I don't think the expression describes all the situation. On my computer,
> now I can left click on bookmark menu, but if I want to right click on a
> special bookmark to let a context menu show on it nothing happens.
I can repo this as well.
str: try to right-click any bookmark in a menu in chrome
Comment 8•10 years ago
|
||
Used to work fine prior to the 3-18 Nightly. I saved the installer for that, and uninstall the 3-18 and reinstall that Nightly, R-click on my bookmarks in folders pops up their context menu. Something broke this functionality.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 9•10 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #7)
> str: try to right-click any bookmark in a menu in chrome
WFM
Nothing happens when you open menu on bookmark with right mouse button and want to select the item with also right mouse button.
Comment 10•10 years ago
|
||
Right clicking doesn't work at least on all bookmark folders, the bookmark menu button and Adblock plus button in the toolbar.
Assignee | ||
Comment 11•10 years ago
|
||
Urgh. Sorry about that, another case of nsEventStatus -> bool. I checked the other callers to make sure I didn't make the same mistake elsewhere this time.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Flags: needinfo?(dvander)
Attachment #8580202 -
Flags: review?(jmathies)
Comment 12•10 years ago
|
||
Comment on attachment 8580202 [details] [diff] [review]
fix
I wonder why our tests did such a lousy job of picking up on this? This affected native event dispatching only maybe?
Attachment #8580202 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #12)
> Comment on attachment 8580202 [details] [diff] [review]
> fix
>
> I wonder why our tests did such a lousy job of picking up on this? This
> affected native event dispatching only maybe?
Yeah, all our tests use purely synthetic dispatch. Kats mentioned we should transition tests to synthesize native widget events instead. I think that's a good idea since it would catch bugs like these. We could do it one widget at a time, too (I might try it just for Windows, after apz bugs are done).
Assignee | ||
Comment 14•10 years ago
|
||
Assignee | ||
Comment 16•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 17•10 years ago
|
||
Confirmed fixed as of 2015-03-19 39.0a1 on 64x Win 7 SP1.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•10 years ago
|
Target Milestone: --- → mozilla39
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•