Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.) Reporter
	Description • 9 years ago

STR:
1. Right click mouse button on some site in non specific space to show up a menu.
2. Select for example "Bookmark This Page" with right click.
3. Nothing will happen.


It's probably a similar regression from bug #1143567, like in was bug #1144081.


[Tracking Requested - why for this release]: Regression


@ David Anderson [:dvander] - Could you look on this issue?

	Jim Jeffery not reading bug-mail 1/2/11
	Comment 2 • 9 years ago

Right-click on 'forward/back' arrow does not produce the history list.  No errors in Browser Console.

	Alice0775 White
	Comment 4 • 9 years ago

Oops, I posted wrong bug
Please ignore comment #3

	Helge Skjeveland
	Comment 5 • 9 years ago

Also happens on my ASUS x64 laptop, no special kbd, etc.

	leichixian
	Comment 6 • 9 years ago

I don't think the expression describes all the situation. On my computer, now I can left click on bookmark menu, but if I want to right click on a special bookmark to let a context menu show on it nothing happens.

	Jim Mathies [:jimm]
	Comment 7 • 9 years ago

(In reply to leichixian from comment #6)
> I don't think the expression describes all the situation. On my computer,
> now I can left click on bookmark menu, but if I want to right click on a
> special bookmark to let a context menu show on it nothing happens.

I can repo this as well.

str: try to right-click any bookmark in a menu in chrome

	Helge Skjeveland
	Comment 8 • 9 years ago

Used to work fine prior to the 3-18 Nightly. I saved the installer for that, and uninstall the 3-18 and reinstall that Nightly, R-click on my bookmarks in folders pops up their context menu. Something broke this functionality.

	Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.) Reporter
	Comment 9 • 9 years ago

(In reply to Jim Mathies [:jimm] from comment #7)
> str: try to right-click any bookmark in a menu in chrome

WFM
Nothing happens when you open menu on bookmark with right mouse button and want to select the item with also right mouse button.

	u428464
	Comment 10 • 9 years ago

Right clicking doesn't work at least on all bookmark folders, the bookmark menu button and Adblock plus button in the toolbar.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 11 • 9 years ago

Urgh. Sorry about that, another case of nsEventStatus -> bool. I checked the other callers to make sure I didn't make the same mistake elsewhere this time.

	Jim Mathies [:jimm]
	Comment 12 • 9 years ago

Comment on attachment 8580202 [details] [diff] [review]
fix

I wonder why our tests did such a lousy job of picking up on this? This affected native event dispatching only maybe?

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 13 • 9 years ago

(In reply to Jim Mathies [:jimm] from comment #12)
> Comment on attachment 8580202 [details] [diff] [review]
> fix
> 
> I wonder why our tests did such a lousy job of picking up on this? This
> affected native event dispatching only maybe?

Yeah, all our tests use purely synthetic dispatch. Kats mentioned we should transition tests to synthesize native widget events instead. I think that's a good idea since it would catch bugs like these. We could do it one widget at a time, too (I might try it just for Windows, after apz bugs are done).

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4510d4116527

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 16 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/4510d4116527

	Helge Skjeveland
	Comment 17 • 9 years ago

Confirmed fixed as of 2015-03-19 39.0a1 on 64x Win 7 SP1.