Closed
Bug 1183710
Opened 9 years ago
Closed 9 years ago
Failure in test_dialer.py, AssertionError: 'telephony' != u'none'
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: alwu)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
I'm getting this failure in the latest build, trying to run this test: TEST-UNEXPECTED-FAIL | test_dialer.py TestDialer.test_dialer_make_call | AssertionError: 'telephony' != u'none' Traceback (most recent call last): File "/Users/mwargers/.virtualenvs/gaia-py-latest/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer.py", line 28, in test_dialer_make_call self.assertEqual('telephony', self.data_layer.current_audio_channel) TEST-INFO took 77404ms I saw this failure already on b2g-inbound for some time. It might be useful to find out when this regressed.
Reporter | ||
Comment 1•9 years ago
|
||
Oh, on b2g-inbound, this seems to be working already, see: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.b2g-inbound.tinderbox.ui.functional.sanity/ So I guess it's just a matter of waiting before this will be fixed on mozilla-central too.
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Martijn Wargers [:mwargers] (QA) from comment #1) > Oh, on b2g-inbound, this seems to be working already, see: > http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.b2g-inbound.tinderbox. > ui.functional.sanity/ > So I guess it's just a matter of waiting before this will be fixed on > mozilla-central too. Oops, that Jenkins run was deactivated at 4 June!
Reporter | ||
Comment 3•9 years ago
|
||
Hrm, I think this is a regression from bug 1113086. Perhaps the patches in bug 1129882 might fix this? At least, if I understand bug 1129882, comment 61 correctly. There is some code, btw, that supposedly can be removed with the fix from bug 1113086: http://mxr.mozilla.org/gaia/search?string=ug%2B1113086
Assignee | ||
Comment 4•9 years ago
|
||
Hi, Martijn, That is another problem. This problem is the same as the bug1177254, if the sound manager can't receive the correct event, that the current audio channel would be wrong. Now we would send this kind of event in Gaia's audio channnel service. If the audio is managed by this service, the event should be sent correctly. However, we have another issue that we can't manage the audio of attention window. I guess this issue is because the test creates the attention window with telephony audio. We can't manage it and send the correct event. If my assumption is correct, this problem would be solved by bug1181982.
Flags: needinfo?(alwu)
Reporter | ||
Updated•9 years ago
|
Assignee: martijn.martijn → nobody
Comment 7•9 years ago
|
||
Comment on attachment 8639825 [details] [gaia] deactivation of the test Our sanity jobs are failing because of this test. Let's deactivate it. Example: http://jenkins1.qa.scl3.mozilla.com/view/Bitbar/job/flame-kk-319.mozilla-central.nightly.ui.functional.sanity.bitbar/311/console
Attachment #8639825 -
Flags: review?(martijn.martijn)
Reporter | ||
Comment 9•9 years ago
|
||
Comment on attachment 8639825 [details] [gaia] deactivation of the test We decided that for deactivation, we wouldn't need review. I would have hoped that bug 1183870 would have been fixed by now. Unfortunately, that still seems to take a while.
Attachment #8639825 -
Flags: review?(martijn.martijn) → review+
Comment on attachment 8639825 [details] [gaia] deactivation of the test Test deactivated in master at: https://github.com/mozilla-b2g/gaia/commit/ba33139c251108308cf882c152d9a7fff001bb83
Attachment #8639825 -
Attachment description: [gaia] mozilla-b2g:bug-1183710 > mozilla-b2g:master → [gaia] deactivation of the test
Blocks: 1188360
Reporter | ||
Comment 11•9 years ago
|
||
Evan, this test is still failing in the latest build, even though bug 1183870 is fixed. Or is this test perhaps wrong? Should the telephony sound be adjusted, using the buttons, during a phone call or the regular sound?
Flags: needinfo?(evan)
Assignee | ||
Comment 12•9 years ago
|
||
See [1], this issue is caused by the bug1185442, and we can fix it in bug1129882. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1198824#c11
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(evan)
Reporter | ||
Comment 14•9 years ago
|
||
Looks like bug 1129882 fixed this, so we can reactivate this test now.
Comment 15•9 years ago
|
||
Reporter | ||
Comment 16•9 years ago
|
||
I'll close the bug once the test is re-enabled in the tree.
Assignee: nobody → alwu
Reporter | ||
Updated•9 years ago
|
Attachment #8665702 -
Flags: review?(npark)
Comment 17•9 years ago
|
||
Comment on attachment 8665702 [details]
[gaia] mwargers:1183710 > mozilla-b2g:master
okay that was simple.
Attachment #8665702 -
Flags: review?(npark) → review+
Reporter | ||
Comment 18•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/ede0a33117d21f006a90cdc1f9a978c0b8a03472 Test re-enabled, this was fixed by bug 1129882.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•