Andrew Comminos [:acomminos] Reporter
	Description • 9 years ago

GTK3 builds now pass all of our Linux test suites (https://treeherder.mozilla.org/#/jobs?repo=elm). We should enable it by default on trunk.

	Andrew Comminos [:acomminos] Reporter
	Comment 1 • 9 years ago

Set the default widget toolkit to cairo-gtk3.

	Mike Hommey [:glandium] Assignee
	Comment 2 • 9 years ago

Comment on attachment 8636569 [details] [diff] [review]
Enable GTK3 builds by default.

Review of attachment 8636569 [details] [diff] [review]:
-----------------------------------------------------------------

There are multiple things involved in doing Gtk3 builds, one of which is this, but the most important part is that Gtk3 dependencies need to be installed. For local development, that means mach bootstrap needs to be installing those dependencies. For automation, that means pulling the gtk3 package from tooltool.

Let's go with the latter to switch to Gtk3 on automation, and deal with the former (along with changing the default in configure.in) in a followup. Essentially, we should just land the patch from bug 1016641 (or, for more security, because I'm not sure it's up-to-date, take the actual diff for elm, filtered-out of the things used for updates). I will do this in a moment,

	Mike Hommey [:glandium] Assignee
	Comment 3 • 9 years ago

The build-gtk3.sh script contains the script used to generate the tooltool
packages.

	Michael Shal [:mshal]
	Comment 4 • 9 years ago

Comment on attachment 8636826 [details] [diff] [review]
Switch automated builds to Gtk+3

>+"filename": "gtk.tar.xz",

I think you want to name these "gtk3.tar.xz" so that tooltool will rm -rf the previous package correctly. I filed bug 1186234 since this is annoying.

I didn't review the build-gtk3.sh script too closely, but it looks reasonable.

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/939320b957c5

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b6c42c745ca

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/939320b957c5
https://hg.mozilla.org/mozilla-central/rev/3b6c42c745ca

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 8 • 9 years ago

I guess that means bug 1179818 doesn't need to worry about gtk?

	Sylvestre Ledru [:Sylvestre]
	Comment 9 • 9 years ago

No longer using this keyword

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 10 • 9 years ago

Mike, could you please fill out the release note request template below? This will help me draft the release notes. Thanks!

Release Note Request (optional, but appreciated)
[Why is this notable]: ???
[Suggested wording]: ???
[Links (documentation, blog post, etc)]: ???

	Mike Hommey [:glandium] Assignee
	Comment 11 • 9 years ago

I'm sure graphics people have more to say than I would.

	Andrew Comminos [:acomminos] Reporter
	Comment 12 • 9 years ago

Release Note Request (optional, but appreciated)
[Why is this notable]: GTK3 provides richer theme support, hidpi widget drawing, better support for input devices, and reduces our dependency on X11. From a graphics perspective, its main advantage is being able to draw widgets onto any kind of system cairo supported surface without readback.
[Suggested wording]: Use GTK+3 for Linux builds
[Links (documentation, blog post, etc)]: Not sure if anyone has written about user-visible changes in Firefox as a result of GTK3.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 13 • 9 years ago

Added relnote to FF41 Beta in Nucleus

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 14 • 9 years ago

This should not be in FF41 release notes but in FF42 instead. Re-setting the flag to ensure it gets look at when the time comes to draft FF42 release notes.

	Dave Garrett
	Comment 15 • 9 years ago

The Linux system requirements also need updating in various places if this is now required.

	Sylvestre Ledru [:Sylvestre]
	Comment 16 • 9 years ago

Added to the release notes of 42 aurora with the wording "GTK3 integration (GNU/Linux only)".
In case this gets delayed to another release, we will update the release notes.

	u544734
	Comment 17 • 9 years ago

Hi, has this been delayed to 43 ? There is no reference to GTK3 in the 42 beta release notes.

	Sylvestre Ledru [:Sylvestre]
	Comment 18 • 9 years ago

(In reply to u544734 from comment #17)
> Hi, has this been delayed to 43 ? There is no reference to GTK3 in the 42
> beta release notes.
Yes, it has been delayed. See bug 1186003.
I just added this item into the 43 release notes but kept the 42 aurora item as it was on during this whole cycle.

	Marco Castelluccio [:marco]
	Comment 19 • 9 years ago

(In reply to Sylvestre Ledru [:sylvestre] from comment #18)
> (In reply to u544734 from comment #17)
> > Hi, has this been delayed to 43 ? There is no reference to GTK3 in the 42
> > beta release notes.
> Yes, it has been delayed. See bug 1186003.

This is bug 1186003.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 20 • 9 years ago

Noting that we disabled gtk3 for 43, last week, here: https://bugzilla.mozilla.org/show_bug.cgi?id=1227024 as there are unresolved update issues.  I'm setting the flags for 42 and 43 to "disabled" on this bug for clarity (since they were enabled for a while on pre-release versions), and re-setting the relnote flag to ?.

	Sylvestre Ledru [:Sylvestre]
	Comment 21 • 9 years ago

44 is disabled too. Let's say that we will try to ship it in 45.
Added to the 45 release notes

	Marco Castelluccio [:marco]
	Comment 22 • 9 years ago

What is missing to ship it?

	Sylvestre Ledru [:Sylvestre]
	Comment 23 • 9 years ago

Itself, the feature is ready.
The problem that we need to address is the update window for system without gtk3.
See bug 1227023.

	Marco Castelluccio [:marco]
	Comment 24 • 9 years ago

I have two questions:
1) Could we ship two versions and update people without GTK3 to the GTK2 version?
2) Could we ship beta and aurora with GTK3, so we have a larger population of testers for the GTK3 version?

Sorry if this has already been asked/answered before.

	Sylvestre Ledru [:Sylvestre]
	Comment 25 • 9 years ago

(In reply to Marco Castelluccio [:marco] from comment #24)
> I have two questions:
> 1) Could we ship two versions and update people without GTK3 to the GTK2
> version?
We could but this would complexify our work and processes.

> 2) Could we ship beta and aurora with GTK3, so we have a larger population
> of testers for the GTK3 version?
It is what we do. 42 beta, 43 beta and 44 aurora had GTK3 enabled by default.
So will 45 aurora (at least).

	ojab
	Comment 26 • 9 years ago

As a side note, will be bug 1227023 statistic available anywhere in public?
I think this info will be useful for other projects in the same situation.

	Sylvestre Ledru [:Sylvestre]
	Comment 27 • 9 years ago

You should ask in the bug itself.

	Robert Kaiser
	Comment 28 • 9 years ago

(In reply to Marco Castelluccio [:marco] from comment #24)
> I have two questions:
> 1) Could we ship two versions and update people without GTK3 to the GTK2
> version?

Once we have the detection in the update URL, we could do that in theory. I expect the GTK2-only population to be very small nowadays though, and given that Linux is already a very small chunk of our users, people getting builds from Mozilla is only a small chunk of Linux users (as most do get builds from their distros), having special builds for yet again a small chunk out of that population probably doesn't make sense, it's better to just unsupport those, and that's the current plan.

	Mayeul C
	Comment 29 • 9 years ago

Oops... It seems the right bug to comment on; not 627699 . My bad. Here is a copy/paste of my comment

Hello, I now have a problem launching Firefox at all. This seems to be a gtk3 issue on my system, because even zenity or gtk3-demo won't start on it.
Bissected the issue to https://hg.mozilla.org/integration/mozilla-inbound/rev/939320b957c5 with mozregression. I just want you to be aware of some problems caused by the transition to gtk3.

I will try to work with gtk developers to get this fixed, but I can't use any updated Firefox version in the meanwhile.

	Daniel Holbert [:dholbert]
	Comment 30 • 9 years ago

mayeul, thanks for the report!  Rather than discussing this as an afterthought on a fixed-weeks-ago-bug, could you file a new bug here for the issue you're seeing:
  https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=Widget:%20Gtk
...and please note the bug number here so that people involved here can take a look on your new bug if they like?

Thanks!

	Mike Hommey [:glandium] Assignee
	Comment 31 • 9 years ago

If you can't even run the gtk3-demo, I doubt there's an actionable bug in Firefox. Your system doesn't have Gtk+3, or is broken in some way. If you get it in a shape where gtk3-demo works but Firefox doesn't, then you can open a new bug.

	Sylvestre Ledru [:Sylvestre]
	Comment 32 • 8 years ago

Should ship in 46

	Andrei Vaida [:avaida]
	Comment 33 • 8 years ago

Mike, is this something manual QE should be looking into for 46? We've done spot checks in the past, the most recent one being on Fx45, for the switch back to gtk2. 

If you think there's value in manually testing gtk3 builds, any tips would help -- we're usually focusing on toolbars, menus, panels, doorhangers and infobars.

	Mike Hommey [:glandium] Assignee
	Comment 34 • 8 years ago

(In reply to Andrei Vaida, QA [:avaida] from comment #33)
> Mike, is this something manual QE should be looking into for 46? We've done
> spot checks in the past, the most recent one being on Fx45, for the switch
> back to gtk2. 
> 
> If you think there's value in manually testing gtk3 builds, any tips would
> help -- we're usually focusing on toolbars, menus, panels, doorhangers and
> infobars.

That seems sensible. You can also pay attention to form elements in web pages.

	Andrei Vaida [:avaida]
	Comment 35 • 8 years ago

(In reply to Mike Hommey [:glandium] from comment #34)
> That seems sensible. You can also pay attention to form elements in web
> pages.

Thanks, we'll make sure this gets looked at during the beta cycle.

	Bogdan Maris, Desktop QA
	Comment 36 • 8 years ago

(In reply to Andrei Vaida, QA [:avaida] from comment #35)
> (In reply to Mike Hommey [:glandium] from comment #34)
> > That seems sensible. You can also pay attention to form elements in web
> > pages.
> 
> Thanks, we'll make sure this gets looked at during the beta cycle.

We did some Exploratory testing on Ubuntu 12.04 and 14.04 using Firefox 46 beta 6 and we did found a few issues, but none of them major. More information can be seen in this raport: https://goo.gl/XBuIH4. Marking as verified fixed on 46 based on our testing.