Martin Stránský [:stransky] (ni? me) Assignee
	Description • 9 years ago

+++ This bug was initially created as a clone of Bug #1211892 +++

follow up from Bug 1211892 comment 17. We should use correct background for text fields (sMozFieldBackground/sMozFieldText).

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 1 • 9 years ago

WIP patch. need to be tested on Ubuntu 12.04, works fine on Fedora/Gtk 3.18.

	Karl Tomlinson (:karlt)
	Comment 2 • 9 years ago

Comment on attachment 8680657 [details] [diff] [review]
background.patch

Thanks.  Feel free to land this as "use GtkTextView for text colors" or similar, even if you don't get a chance to test on Ubuntu 12.04, because it is the right thing to do.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 3 • 9 years ago

Ubuntu 12.04 looks fine with this patch. No big difference from Gtk2 version.

	Martin Stránský [:stransky] (ni? me) Assignee
	Comment 4 • 9 years ago

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc332babcff1

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/95e4a598daf7

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/95e4a598daf7

	Karl Tomlinson (:karlt)
	Comment 7 • 9 years ago

Blocking bug 1193807 to indicate that we should uplift this before shipping the GTK3 build.

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/95e4a598daf7

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

	Karl Tomlinson (:karlt)
	Comment 11 • 9 years ago

Comment on attachment 8681348 [details] [diff] [review]
patch for check-in

Approval Request Comment
[Feature/regressing bug #]: bug 1186229
[User impact if declined]:
The effects of this can range from unhelpful background colors on older Ubuntu
distributions
(http://i.imgur.com/3yRWX0Z.png reported in bug 1211892 comment 7.)
to completely unreadable text in other themes, include defaults of other
distributions (bug 1216246).
[Describe test coverage new/current, TreeHerder]:
None.  Colors depend on themes.
[Risks and why]: 
Some risk of ending up with inappropriate colors in some untested themes, but
I confident that the logic here should give us colors that are consistent with
GTK in more situations.
[String/UUID change made/needed]:
None.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 12 • 9 years ago

Comment on attachment 8681348 [details] [diff] [review]
patch for check-in

Theme changes for readability with gtk3, ok to uplift to aurora and beta.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 13 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/b883b0c1507c

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 14 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/a59d9d8978ad

	Carsten Book [:Tomcat]
	Comment 15 • 9 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b883b0c1507c

	Bogdan Maris, Desktop QA
	Comment 16 • 9 years ago

Reproduced the initial issue using an old Nightly build 2015-10-08, verified using Firefox 43 beta 3, latest Developer Edition 44.0a2 (Light Theme) and latest Nightly 45.0a1 on Ubuntu 12.04 32-bit.