Closed Bug 1187394 Opened 9 years ago Closed 9 years ago

Move Backfill job link from Job details to Job details Action bar

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

Details

Attachments

(2 files)

Per the discussion in IRC, we'd like to move the current action for Backfill job, from the Job details pane (which mostly just presents information) to the Job details Action bar. So we don't end up exceeding the action bar width, I pose we go with a drop down menu where: - our current retrigger icon is the menu selector - our current retrigger icon maintains its green hover behavior And when the user clicks on the icon, instead of retriggering, we post a menu containing: Retrigger job Retrigger job on previous pushes* * perhaps more informative than "Backfill" from a first time user perspective? I defer to you guys. If Backfill is a universally understood concept, then yah go with Backfill. I just didn't know precisely what it meant until I read the link title :) Since we have 'r' as a shortcut for retrigger, I don't consider moving that function inside a menu as a UX issue. Users can use the shortcut if they wish.
Attached image moveBackfillJobslink (deleted) —
Screen grab of current implementation, with proposed location.n
Vaibhav, curious were you planning on working on this as a follow up?
Flags: needinfo?(vaibhavmagarwal)
:jfrench, I plan to work on this, but I am a bit occupied with another bug. You can take this up if you want :)
Flags: needinfo?(vaibhavmagarwal)
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
I'm getting close to a PR. I chatted with :kwierso in channel - he's indicated as a follow up we may want to either a) provide a confirmation prompt for Backfilling or b) mimic the Save classification 'Save|>' UI cluster in the job details actionbar for Backfilling, so Backfill job is less 'selectable' (but which will consume more space in the actionbar) or c) add a menu divider to the menu I'm planning to add, so "Retrigger job" and "Backfill job" are a little more separated during selection
Attached file PR 958 (deleted) —
PR for review :)
Attachment #8659974 - Flags: review?(cdawson)
Attachment #8659974 - Flags: review?(cdawson) → review+
Marking fixed per above merge. Will verify on the next push to stage/prod :)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on production.
Status: RESOLVED → VERIFIED
No longer blocks: 1207460
Depends on: 1207460
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: