Closed Bug 1207398 Opened 9 years ago Closed 9 years ago

Disable the "backfill job" menu item for jobs on try repositories

Categories

(Tree Management :: Treeherder, defect)

Product:
Tree Management
Component:
Treeherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(1 file)

PR 1102
(deleted), text/x-github-pull-request
emorley
: review+
Details
I don't think it makes sense to have the "backfill" option on try repos, since you'd be triggering jobs on other people's pushes, maybe causing confusion? (Actually, does it even work on Try?)
Attached file PR 1102 (deleted) —
This is a quick one-line patch to hide the backfill button on try repos. As noted in the PR, there's a consistency issue with it, but it's not (IMO) terrible. There's a few alternatives, but those are more than one-line patches. :)
Assignee: nobody → wkocher
Status: NEW → ASSIGNED
Attachment #8680965 - Flags: review?(emorley)
Comment on attachment 8680965 [details] PR 1102 Have left a comment :-)
Attachment #8680965 - Flags: review?(emorley)
Comment on attachment 8680965 [details] PR 1102 I think this should work.
Attachment #8680965 - Flags: review?(emorley)
Updating bug summary to reflect what this is doing now.
Summary: Hide the "backfill job" menu item for jobs on try repositories → Disable the "backfill job" menu item for jobs on try repositories
Attachment #8680965 - Flags: review?(emorley)
Flags: needinfo?(wkocher)
Flags: needinfo?(wkocher)
Comment on attachment 8680965 [details] PR 1102 And I think this is done. The second commit can either be squashed in before landing or dropped, but I think it does help the readability of the html file.
Attachment #8680965 - Flags: review?(emorley)
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/3ada40c569151c24eb2903a7a93a4f00db0aeee9 Bug 1207398 - Disable the backfill button on try repos (#1102) * Bug 1207398 - Disable the backfill button on try repos * Move long strings into controller.js to make the html shorter
Attachment #8680965 - Flags: review?(emorley) → review+
Thank you :-) (Didn't mean to merge it myself, accidentally pressed merge not cancel on the green button when exploring the new squash-and-merge feature, but doesn't matter I guess :-))
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: