Closed
Bug 121774
Opened 23 years ago
Closed 14 years ago
<popupset> is deprecated, you can put your context menu popups all by themselves.
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: timeless, Unassigned)
References
()
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Comment 1•22 years ago
|
||
The deprecation of popupset shouldn't seriously affect performance or operation
of DOM Inspector. If you desire, you can assign this bug to me.
Severity: normal → trivial
Updated•20 years ago
|
Product: Core → Other Applications
Comment 3•19 years ago
|
||
Reassigning DOM-I bugs which have stagnated in my buglist back to default owner. Hopefully someone will pick up some of these bugs and work on them. I'll continue to follow them.
Assignee: ajvincent → dom-inspector
Target Milestone: Future → ---
Updated•18 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Comment 4•18 years ago
|
||
Seems to work for me, but I'd like someone else to test this before I request review.
Assignee: dom-inspector → comrade693+bmo
Status: NEW → ASSIGNED
Updated•18 years ago
|
Attachment #246107 -
Flags: review?(db48x)
Comment 5•18 years ago
|
||
Comment on attachment 246107 [details] [diff] [review]
v1.0
r=db48x
Attachment #246107 -
Flags: review?(db48x) → review+
Updated•18 years ago
|
Attachment #246107 -
Flags: superreview?(neil)
Comment 6•18 years ago
|
||
Comment on attachment 246107 [details] [diff] [review]
v1.0
This doesn't even work, probably because the overlays key off the popupset id.
Attachment #246107 -
Flags: superreview?(neil) → superreview-
Comment 7•18 years ago
|
||
Funny...my build must have lied to me... This time I did a full clean build (as in bye bye object director, lets start fresh).
Alright, so I did extensive checking this time around, and this should get everything. I even had to modify a test file that uses inspector code... From basic playing around, everything seems to work correctly still.
I removed commented out code that I would have had to modify because I was changing id's.
Attachment #246107 -
Attachment is obsolete: true
Attachment #248721 -
Flags: review?(db48x)
Comment 8•18 years ago
|
||
minor typo broke the styleRules pane
Attachment #248721 -
Attachment is obsolete: true
Attachment #248751 -
Flags: review?(db48x)
Attachment #248721 -
Flags: review?(db48x)
Updated•18 years ago
|
Attachment #248751 -
Flags: review?(db48x)
Comment 9•18 years ago
|
||
Nothing looks busted, and this removes a bunch of search code that's been commented out for who knows how long and cleans up formatting in places.
It should be noted that you need to do a full build when applying this patch because just running make in extensions/inspector doesn't seem to update the changes made in jar.mn (this only applies to Firefox, not Seamonkey I think)
Attachment #248751 -
Attachment is obsolete: true
Attachment #249204 -
Flags: review?(db48x)
Comment 10•18 years ago
|
||
I need to remove this from the CSS too - somehow I missed it
http://mxr-test.landfill.bugzilla.org/mxr-test/seamonkey/source/extensions/inspector/resources/content/inspector.css#57
Updated•18 years ago
|
Attachment #249204 -
Flags: review?(db48x)
Updated•18 years ago
|
QA Contact: timeless → dom-inspector
Updated•17 years ago
|
Assignee: comrade693+bmo → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug]
Comment 11•14 years ago
|
||
WONTFIX?
Firefox (Bug 535974) and SeaMonkey (Bug 572682) have moved/are moving all popups, panels, and tooltips into popupsets.
Comment 12•14 years ago
|
||
(In reply to comment #11)
Yep.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Comment 13•14 years ago
|
||
Oh yea, see bug 578775.
You need to log in
before you can comment on or make changes to this bug.
Description
•