Closed
Bug 1234118
Opened 9 years ago
Closed 9 years ago
Clean up code for handling 'do-command' and 'copypaste-docommand'
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
In BrowserElementChildPreload.js and BrowserElementParent.js, we add code to support 'copypaste-docommand' and 'do-command' to handle to copy/paste/cut operation from text_selection_dialog.js in Gaia. We need to clean it up since SelectionCarets and text_selection_dialog.js are removed in bug 1221459 and bug 1221462.
Also the test case at [1] might need to be revised.
[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/dom/browser-element/mochitest/browserElement_CopyPaste.js#92
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tlin
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29021/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29021/
Attachment #8701671 -
Flags: review?(mtseng)
Comment 2•9 years ago
|
||
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
https://reviewboard.mozilla.org/r/29021/#review25839
Attachment #8701671 -
Flags: review?(mtseng) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 -
Flags: review?(bugs)
Comment 4•9 years ago
|
||
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
https://reviewboard.mozilla.org/r/29021/#review25915
Odd code. I wonder why we had two almost the same notifications and message types.
Attachment #8701671 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thank you for the review! That's why wee need to delete the obsolete code to avoid confusion :)
Comment 7•9 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=19064831&repo=mozilla-inbound
Flags: needinfo?(tlin)
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 -
Attachment description: MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand' → MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
Assignee | ||
Comment 10•9 years ago
|
||
Latest try (B2G ICS Emulator green!)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29a34873a6d4
Flags: needinfo?(tlin)
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•