Closed Bug 1320448 Opened 8 years ago Closed 8 years ago

Port bug 1305453 [Prevent non-esr stand alone installers from installing SeaMonkey on XP/Vista (2.50 and up) ] and Bug 1276324 [Don't install on systems that have a CPU that doesn't support SSE2]

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Version:
SeaMonkey 2.49 Branch
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.47 wontfix, seamonkey2.48 wontfix, seamonkey2.49esr fixed, seamonkey2.50 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.49
Tracking Flags:
Tracking Status
seamonkey2.47 --- wontfix
seamonkey2.48 --- wontfix
seamonkey2.49esr --- fixed
seamonkey2.50 --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(2 files)

1320448-NOXPVistaSSEInstall.patch
(deleted), patch
iannbugzilla
: review+
Details | Diff | Splinter Review
1320448-NOSSEInstall-Aurora.patch
(deleted), patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1319469 +++ From bug 1305453: (In reply to Jim Mathies [:jimm] from comment #0) > We plan to eol XP/Vista by first moving those users out to ESR 52. Once 52 > merges to aurora, we should land changes to the stand alone installer to > prevent install by XP and Vista users. Initially there shouldn't be an issue > with running but eventually we'll import a system dependency that will break > browser startup.
This also takes care of checking for an SSE2 capable COU during install. I will close bug 1276324 (orginally Bug 1271759 for FF) as a duplicate. Both Bugs are intertwined because the same codepath needs to change.
Assignee: installer → frgrahl
Status: NEW → ASSIGNED
Attachment #8820287 - Flags: review?(philip.chee)
Attachment #8820287 - Flags: review?(iann_bugzilla)
Attachment #8820287 - Flags: feedback?(bugzilla)
status-seamonkey2.47: --- → wontfix
status-seamonkey2.48: --- → wontfix
status-seamonkey2.49esr: unaffected → affected
Summary: Port bug 1305453 [Prevent non-esr stand alone installers from installing SeaMonkey on XP/Vista (2.50 and up) ] → Port bug 1305453 [Prevent non-esr stand alone installers from installing SeaMonkey on XP/Vista (2.50 and up) ] and Bug 1276324 [Don't install on systems that have a CPU that doesn't support SSE2]
SSE2 part only for SeaMonkey 2.49. I think this should go in despite the string changes because we might do an ESR. [Approval Request Comment] Regression caused by (bug #): 1276324 User impact if declined: Installation succeeds but SeaMonkey not working. Testing completed (on m-c, etc.): c-a with Vista x86 X64 XP SP 3 and Server 2003 Risk to taking this patch (and alternatives if risky): Users ned up with a non working browser on older PCs. String changes made by this patch: suite/branding/nightly/package/windows/branding.nsi: +!define URLSystemRequirements suite/locales/en-US/installer/windows/custom.properties: +WARN_MIN_SUPPORTED_CPU_MSG +WARN_MIN_SUPPORTED_OSVER_MSG +WARN_MIN_SUPPORTED_OSVER_CPU_MSG -WARN_UNSUPPORTED_MSG Website needs to be updated too.
Attachment #8820289 - Flags: review?(philip.chee)
Attachment #8820289 - Flags: review?(iann_bugzilla)
Attachment #8820289 - Flags: approval-comm-aurora?
For c-a: I just now saw that InstallOnInitCommon also does generic SSE2 and version checks. So the install would just quit with a wrong error message about an unsupported OS and not install a non working browser.
Comment on attachment 8820287 [details] [diff] [review] 1320448-NOXPVistaSSEInstall.patch r/a=me
Attachment #8820287 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8820289 [details] [diff] [review] 1320448-NOSSEInstall-Aurora.patch r/a=me with relevant notes going out about late string changes.
Attachment #8820289 - Flags: review?(iann_bugzilla)
Attachment #8820289 - Flags: review+
Attachment #8820289 - Flags: approval-comm-aurora?
Attachment #8820289 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/bb3933123f2d25578768d1e00eafd760ce2afe18 https://hg.mozilla.org/releases/comm-aurora/rev/af388125e404550ca52ae2f82bdc5c0bdac29e54
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-seamonkey2.49esr: affected → fixed
status-seamonkey2.50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
Version: unspecified → SeaMonkey 2.49 Branch
Attachment #8820287 - Flags: review?(philip.chee)
Attachment #8820289 - Flags: review?(philip.chee)
Attachment #8820287 - Flags: feedback?(bugzilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: