Mike Conley (:mconley) (:⚙️) Reporter
	Description • 7 years ago

This summary might not be 100% clear, but the attached screenshot might help.

Interestingly, this only seems to affect tabs that have titles long enough to fade on the right side.

I remember showing this to nhnt11 when we were fiddling with vibrancy in SF, and there was some macOS accessibility setting that seemed to affect this involving text smoothing, but I can't find the setting... nhnt11, do you remember what that setting was?

	Mike Conley (:mconley) (:⚙️) Reporter
	Comment 2 • 7 years ago

Any idea what's happening here, mstange?

	Markus Stange [:mstange] Assignee
	Comment 3 • 7 years ago

Either something's wrong with the mask's PushGroupAndCopyBackground, or we're giving some intermediate surface the wrong FontSmoothingBackgroundColor, or something else is broken. I'll look into it.

	(inactive) Nihanth Subramanya [:nhnt11]
	Comment 5 • 7 years ago

(In reply to Mike Conley (:mconley) - Buried in needinfo / review backlog, eating my way out from comment #0)
> Created attachment 8892915 [details]
> Bold title
> 
> This summary might not be 100% clear, but the attached screenshot might help.
> 
> Interestingly, this only seems to affect tabs that have titles long enough
> to fade on the right side.
> 
> I remember showing this to nhnt11 when we were fiddling with vibrancy in SF,
> and there was some macOS accessibility setting that seemed to affect this
> involving text smoothing, but I can't find the setting... nhnt11, do you
> remember what that setting was?

That setting is "Use LCD font smoothing when available" in System Preferences' General pane.

	:Gijs (he/him)
	Comment 7 • 7 years ago

Cameron, is this what you were seeing earlier and mentioned on slack? :-)

	Jared Lockhart [:jlockhart]
	Comment 9 • 7 years ago

This also happens when you mouse over, and it seems to affect the URL bar too, here's a video:

https://www.dropbox.com/s/9eqba6tbigpde4t/tab%20font%20weirdness.mov?dl=0

	Cameron McCormack (:heycam)
	Comment 11 • 7 years ago

(In reply to :Gijs from comment #7)
> Cameron, is this what you were seeing earlier and mentioned on slack? :-)

It is indeed, thanks!

	Tracy Walker [:tracy]
	Comment 15 • 7 years ago

This seems to only happen in the default theme.  It doesn't happen with Light or Dark themes from customize options.  I switched to the Light theme several days ago to avoid the flickery/focusy issue on tab hover.

	Sören Hentzschel
	Comment 16 • 7 years ago

I wonder what this priority means. It's a visual regression in the default theme and it's a visual regression in one of the most important parts of the user interface of the browser: the tabs. And the flickering is *very* annoying. So this should be rather a P1 than a P4, no?

	Markus Stange [:mstange] Assignee
	Comment 17 • 7 years ago

I agree.

	Jeff Muizelaar [:jrmuizel]
	Comment 18 • 7 years ago
mozreview-review

Comment on attachment 8893111 [details]
Bug 1386643 - Don't respect font smoothing background colors in pushed layers.

https://reviewboard.mozilla.org/r/164114/#review171724

	Pulsebot
	Comment 19 • 7 years ago

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/b75150e59554
Don't respect font smoothing background colors in pushed layers. r=jrmuizel

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 21 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/b75150e59554

	Sören Hentzschel
	Comment 22 • 7 years ago

It's not fixed. I looks a bit different now, but the problem is still there.

	Albert Scheiner [:alberts]
	Comment 24 • 7 years ago

On macOS (10.11) it seems that the effect on the active tab and the URL bar has been fixed. Only the background tabs still show the font-weight change on hover.

	Markus Stange [:mstange] Assignee
	Comment 25 • 7 years ago

This bug was about the selected tab, which is no longer strangely bold.

The bug about bad text anti-aliasing when hovering background tabs needs a separate fix and will be tracked in bug 1389476.

	Sören Hentzschel
	Comment 26 • 7 years ago

(In reply to Markus Stange [:mstange] from comment #25)
> This bug was about the selected tab, which is no longer strangely bold.
> 
> The bug about bad text anti-aliasing when hovering background tabs needs a
> separate fix and will be tracked in bug 1389476.

well, this was not clear since I reported the issue already 10 days ago and my ticket was marked as duplicate of this ticket. Okay, I'll follow the other ticket. Thanks. ;)