Closed Bug 1391658 Opened 7 years ago Closed 7 years ago

Enable `curly`, `object-curly-spacing` rules per airbnb recommendations

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: ShrutiJ)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In the review of bug 1329224, these eslint rules came up: https://eslint.org/docs/rules/curly https://eslint.org/docs/rules/object-curly-spacing I also noticed some violations of the airbnb recommendations for quote-props in our code while looking into this bug: https://eslint.org/docs/rules/quote-props It would be good to add them to our list of rules. The parameters should be (per the airbnb guidelines): curly: ['error', 'multi-line'] object-curly-spacing: ['error', 'always'] quote-props: ['error', 'as-needed', { keywords: false, unnecessary: true, numbers: false }] Shruti, can you take of this? You can follow the template specified in any number of the bugs depending on bug 1183749. There about most likely existing violations of the rule. You should be able to fix many/most of the existing violations automatically by running: ./node_modules/eslint/bin/eslint.js --ext .js,.jsx ui/
Attachment #8899527 - Flags: review?(wlachance)
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e8fb2cefb5e86738419b02d5fa00795ea46fa107 Bug 1391658 - Enable `curly`, `object-curly-spacing`, `quote-props` and `key-spacing`rules as per airbnb recommendations (#2724) Bug 1391658 - Enable `curly`, `object-curly-spacing`, `quote-props`, `key-spacing` rules as per airbnb recommendation
Comment on attachment 8899527 [details] [treeherder] SJasoria:1391658 > mozilla:master Thank you! Looks good now.
Attachment #8899527 - Flags: review?(wlachance) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: