As of bug 1184614, all default eslint rules that we were already passing, are enabled. We should now: 1) Fix the default rules that are failing (that we agree we want to use), and remove the entries disabling them. 2) Assess the "off by default" rules (see: http://eslint.org/docs/rules/) to see if any are ones we also want. The default rules we've currently had to disable, are: camelcase - require camel case names comma-dangle - disallow or enforce trailing commas comma-spacing - enforce spacing before and after comma consistent-return - require return statements to either always or never specify values curly - specify curly brace conventions for all control statements dot-notation - encourages use of dot notation whenever possible eol-last - enforce newline at the end of file, with no multiple empty lines eqeqeq - require the use of === and !== global-strict - (deprecated) require or disallow the "use strict" pragma in the global scope key-spacing - enforces spacing between keys and values in object literal properties no-alert - disallow the use of alert, confirm, and prompt no-console - disallow use of console no-extra-semi - disallow unnecessary semicolons no-loop-func - disallow creation of functions within loops no-multi-spaces - disallow use of multiple spaces no-redeclare - disallow declaring the same variable more than once no-shadow - disallow declaration of variables already declared in the outer scope no-undef - disallow use of undeclared variables unless mentioned in a /*global */ block no-underscore-dangle - disallow dangling underscores in identifiers no-unused-vars - disallow declaration of variables that are not used in the code no-use-before-define - disallow use of variables before they are defined quotes - specify whether backticks, double or single quotes should be used semi - require or disallow use of semicolons instead of ASI semi-spacing - enforce spacing before and after semicolons space-infix-ops - require spaces around operators space-unary-ops - Require or disallow spaces before/after unary operators (words on by default, nonwords off by default)

Bug 1185108 - Use and enforce 4 space indentation everywhere in Treeherder JS (resolved fixed above).

So ESLint v1.0.0rc1 has been released, which changes a number of things: http://eslint.org/docs/1.0.0/user-guide/migrating-to-1.0.0 tl;dr they've switched to always having the equivalent of --reset enabled, and you can now use the "eslint:recommended" option to enable _most_ of the rules that were enabled by default in earlier versions of ESLint. Anyway, I think we should wait until the final release, and then update to it, before investing to much time in tweaking the current eslint config.

We're currently using grunt-eslint v16.0.0 in testing/in out package.json which uses the 0.x release of eslint. Updating to grunt-eslint v17.1.0 makes us switch to eslint 1.x, which causes tests the tests to fail, so I've excluded it from the version updates I've done in bug 1206670.

Eventually it would be good to enable all the rules in the airbnb style guide: http://airbnb.io/javascript/ Neutrino has a preset for it: https://neutrino.js.org/presets/neutrino-preset-airbnb-base/ I don't really have time to really do this atm, so I'm just adding individual rules that correspond to this guide as they come up in reviews. However, this would be a nice thing for someone motivated to do. :)

Yeah I agree - ideally we should have no (or very few) exceptions to the airbnb preset.