Closed
Bug 1407656
Opened 7 years ago
Closed 7 years ago
Fennec bouncer aliases in-tree task
Categories
(Release Engineering :: Release Automation: Other, enhancement, P1)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mozilla
:
feedback+
Callek
:
feedback+
|
Details | Diff | Splinter Review |
Let's build a bbb task in-tree for updating Fennec bouncer aliases. This should work (with minimal changes) for Firefox as well.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Based on top of the patch from bug 1407637. I have a few concerns:
* Do the properties like tuxedo_server_url belong to here?
* resolve_keyed_by usage is a bit awkward to me. What's wrong with me? :)
Attachment #8917558 -
Attachment is obsolete: true
Attachment #8917581 -
Flags: feedback?(bugspam.Callek)
Attachment #8917581 -
Flags: feedback?(aki)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8917581 [details] [diff] [review]
bug1407656-bouncer-aliases.diff
I think you should land this on maple :)
Attachment #8917581 -
Flags: feedback?(aki) → feedback+
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8917581 [details] [diff] [review]
bug1407656-bouncer-aliases.diff
Review of attachment 8917581 [details] [diff] [review]:
-----------------------------------------------------------------
::: taskcluster/taskgraph/transforms/job/buildbot.py
@@ +78,5 @@
> def mozharness_on_buildbot_bridge(config, job, taskdesc):
> + # resolve by-* keys first
> + fields = [
> + "run.properties.tuxedo_server_url",
> + ]
I'm really not a fan of using run.properties.* here explicitly, maybe we do make the entire properties a by-project in the .yml?
Or give this another intermediate transform?
Attachment #8917581 -
Flags: feedback?(bugspam.Callek) → feedback+
|
|
Assignee | |
Comment 6•7 years ago
|
||
This is on central now
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•