[meta] [gtk] [fission] Remove full-native theming for content (Linux NNT)
Categories
(Core :: Widget: Gtk, task, P2)
Tracking
()
Fission Milestone | M7a |
People
(Reporter: Paul.Hancock.17041993, Unassigned)
References
(Blocks 2 open bugs)
Details
(Keywords: meta, Whiteboard: [fingerprinting][overhead:noted][fp-triaged])
Reporter | ||
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Comment 4•7 years ago
|
||
Reporter | ||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Updated•7 years ago
|
Comment 11•7 years ago
|
||
Reporter | ||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Reporter | ||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Reporter | ||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Comment 18•7 years ago
|
||
Comment 19•7 years ago
|
||
Comment 20•7 years ago
|
||
Reporter | ||
Comment 21•7 years ago
|
||
Comment 22•7 years ago
|
||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Comment 25•7 years ago
|
||
Comment 26•7 years ago
|
||
Comment 27•7 years ago
|
||
Comment 28•7 years ago
|
||
Comment 29•7 years ago
|
||
Comment 30•7 years ago
|
||
Comment 31•7 years ago
|
||
Comment 32•7 years ago
|
||
Comment 33•7 years ago
|
||
Comment 34•7 years ago
|
||
Comment 35•7 years ago
|
||
Comment 36•7 years ago
|
||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 38•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 39•6 years ago
|
||
you could just add 'env GTK_THEME=Adwaita' to the .desktop which is created when you press the 'Make default' button in settings
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 42•5 years ago
|
||
Why isn't "widget.content.gtk-theme-override" set to "Adwaita:light" by default? this would fix this issue.
Comment 43•5 years ago
|
||
Setting the override is not enough. I have that set and the Find (Ctrl-F) text entry is white on white for example.
Comment 44•5 years ago
|
||
Idk why this is such a big issue. There is the GTK_THEME= variable and the various AMO themes.
So if you use a dark theme, start FF with it's bright variant via the variable and pick a dark theme from AMO you like.
Comment 45•5 years ago
|
||
(In reply to x3 from comment #44)
Idk why this is such a big issue. There is the GTK_THEME= variable and the various AMO themes.
So if you use a dark theme, start FF with it's bright variant via the variable and pick a dark theme from AMO you like.
It is not just that we want to use a dark theme, we also want Firefox to match our system’s dark theme. The Dark theme bundled with Firefox or any theme on AMO just will not do – they might be dark but the shades of grey are slightly off, which is pretty irksome. The AMO theme will either be slightly darker than the system theme and then, when you switch to a different window, you will be blinded, or it will be slightly lighter and you will be blinded when switching back to Firefox. Only the Default theme supports basing its colours on operating system’s theme.
Comment 46•5 years ago
|
||
(In reply to Jan Tojnar from comment #45)
(In reply to x3 from comment #44)
I haven't looked into it but I assume anyone can edit and submit themes to AMO
so just edit one replacing some of it's colors with the ones used in your GTK theme
then Firefox's "header" will match it but the page will be "normal" with GTK_THEME=Arc (for e.g.)
Comment 47•5 years ago
|
||
(In reply to john from comment #46)
I haven't looked into it but I assume anyone can edit and submit themes to AMO
so just edit one replacing some of it's colors with the ones used in your GTK theme
then Firefox's "header" will match it but the page will be "normal" with GTK_THEME=Arc (for e.g.)
Unless there is an API themes can use to query the system GTK theme for colours of various elements, it would require to create a Firefox theme for every different GTK theme. And after that the themes would have to be forever kept in sync:
Adwaita changes colour tone? Update the Firefox theme. Wait, Bob is using Ubuntu LTS where the Adwaita change did not yet arrive. Now he must roll back to an older version of Firefox theme. And not forget to update the theme manually on next Ubuntu upgrade.
This is simply too much effort for something so natural as a consistent system look. I can still remember the pain when every multimedia application decided to draw its own GUI and you had to crawl their theme portals, trying to find a single theme up to date and matching your system look. Thankfully those days are mostly over for regular apps.
Comment 48•5 years ago
|
||
(In reply to Jan Tojnar from comment #47)
i doubt it is much effort to change a few color hexes and gtk themes (that aren't abandoned) aren't really that many
Comment 49•5 years ago
|
||
(In reply to john from comment #48)
(In reply to Jan Tojnar from comment #47)
i doubt it is much effort to change a few color hexes and gtk themes (that aren't abandoned) aren't really that many
It's not much effort for web designers to actually specify both background and foreground colors for elements like buttons and other input elements, but in reality they just don't do that.
Availability of workarounds is really not the point of this bug. The point of this bug is that out of the box Firefox doesn't work the way some users (and apparently, many web designers) expect it to.
Comment 50•5 years ago
|
||
(In reply to Rimas Kudelis from comment #49)
Availability of workarounds is really not the point of this bug. The point of this bug is that out of the box Firefox doesn't work the way some users (and apparently, many web designers) expect it to.
what way is that
Comment 51•5 years ago
|
||
(In reply to mike from comment #3)
Please for the love of all that is mozilla, make this happen. I rarely
login to comment on things, but I am so tired of fighting with GTK on linux
with Firefox. Please instead of acquiescing by allowing different themes
just get rid of it altogether like chrome. (I hate saying "like chrome" but
here it applies)
just use the GTK_THEME= variable
simple as
Comment 52•5 years ago
|
||
(In reply to Paul17041993 from comment #14)
(In reply to x3 from comment #13)
(In reply to Paul17041993 from comment #12)
You seem confused, QT's default dialogues are very close to native and
perfectly usable, they can also be customised. GTK+'s on the other hand are
really dumb, backwards and not user friendly...I don't know what you by native. I have seen Qt5's open/save window and it
is in no way superior to gtk(2 for that matter). The one in kde is. I
suspect the one who is confused is you.OS? because QT's default structure is very much native to windows
yep you've never seen the Qt open/save as window, you're thinking of kdialog
Updated•5 years ago
|
Comment 53•5 years ago
|
||
FWIW these days you can just use widget.disable-native-theme-for-content=true
to disable the native theme.
Comment 54•5 years ago
|
||
That also doesn't fix the white text on white background I get in the Find (Ctrl-F) text entry.
Comment 55•5 years ago
|
||
Can you file a separate bug for that and needinfo me with your GTK setup / theme? That's not affected by that pref because it's Firefox UI (not content).
From a quick look, it seems that field is doing the right thing (it's setting the color to be -moz-FieldText
, and the background to be -moz-Field
, which are the right GTK background colors).
I'm happy to poke at it but that specific bit seems unrelated to this bug.
Comment 56•5 years ago
|
||
Sure, submitted as Bug 1634449. It was my mistake. I subscribed to this bug as well as 70315 and replied here instead of there.
Comment 57•4 years ago
|
||
Tracking Linux NNT as a Fission Nightly blocker. Removing native theming from the content process will help alleviate Fission's problems with X connection exhaustion (bug 1129492).
Updated•4 years ago
|
Updated•4 years ago
|
Comment hidden (advocacy) |
Comment 60•4 years ago
|
||
Tracking non-native theming bugs for Fission Beta milestone (M7).
Updated•4 years ago
|
Updated•4 years ago
|
Comment 62•4 years ago
|
||
Linux bugs don't block our Fission Beta experiment (on Windows and macOS), so I am moving Linux Fission bugs from Fission milestone M7 to M7a.
Updated•4 years ago
|
Comment 63•4 years ago
|
||
I think with bug 1697053 we can call this fixed.
Description
•