Closed Bug 1416317 Opened 7 years ago Closed 7 years ago

followup notification fixes to bug 1412690

Categories

(Release Engineering :: Release Automation: Other, enhancement)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mozilla, Assigned: garbas)

References

Details

User Story

what have i checked already has task_notifications implemented in-tree

- [x] desktop/beetmove_image.yml.tmpl
- [x] desktop/checksums.yml.tmpl
- [x] desktop/enUS.yml.tmpl
- [x] desktop/funsize_image.yml.tmpl
- [x] desktop/l10n.yml.tmpl
- [x] desktop/l10n_changesets.yml.tmpl
- [x] desktop/publish_balrog.yml.tmpl
- [x] desktop/bb_update_verify.yml.tmpl
- [x] desktop/binary_transparency.yml.tmpl
- [x] desktop/bouncer.yml.tmpl
- [x] desktop/bouncer_aliases.yml.tmpl
- [x] desktop/final_verify.yml.tmpl
- [x] desktop/mark_as_shipped.yml.tmpl
- [x] desktop/partner_repacks.yml.tmpl
- [x] desktop/push_to_releases.yml.tmpl
- [x] desktop/snap.yml.tmpl
- [x] desktop/source.yml.tmpl
- [x] desktop/tc_update_verify.yml.tmpl
- [x] desktop/updates.yml.tmpl
- [x] desktop/uptake_monitoring.yml.tmpl
- [x] desktop/version_bump.yml.tmpl

Attachments

(2 files, 1 obsolete file)

notifications-follow-up.patch
(deleted), patch
mozilla
: review+
Details | Diff | Splinter Review
notifications-follow-up-2.patch
(deleted), patch
mozilla
: review+
Details | Diff | Splinter Review
Let's rework notifications - this is a pretty large set of changes. Spun off from bug 1415391. This is good for code cleanliness. We are planning on changing to taskcluster notifications at some point, so we shouldn't spend too many days on this. https://bugzilla.mozilla.org/show_bug.cgi?id=1412690#c56 https://bugzilla.mozilla.org/show_bug.cgi?id=1412690#c58
Assignee: nobody → rgarbas
Status: NEW → ASSIGNED
Attached patch notifications-follow-up.patch (obsolete) (deleted) — — Splinter Review
not yet done with the patch, but getting close. this is a preview if i'm on the right path.
Attachment #8934675 - Flags: review?(aki)
Attachment #8934675 - Flags: review?(aki) → feedback+
User Story: (updated)
User Story: (updated)
Attached patch notifications-follow-up.patch (deleted) — — Splinter Review
This patch is ready to be landed to maple, I rebased my work on current master. There is still some work to be done to finish this ticket, but I would like to get this merged asap since it is touching a lot of files.
Attachment #8934675 - Attachment is obsolete: true
Attachment #8934719 - Flags: review?(aki)
Comment on attachment 8934719 [details] [diff] [review] notifications-follow-up.patch Landed on maple, ty!
Attachment #8934719 - Flags: review?(aki) → review+
User Story: (updated)
Attached patch notifications-follow-up-2.patch (deleted) — — Splinter Review
last bits of notifications
Attachment #8935174 - Flags: review?(aki)
Comment on attachment 8935174 [details] [diff] [review] notifications-follow-up-2.patch Lgtm. The `if shipping-phase...` stuff can probably be in a loop, like for k in ['shipping-phase', 'shipping-name', 'notifications']: if k in job: job_description[k] = job[k] but I'm not going to block on that.
Attachment #8935174 - Flags: review?(aki) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: