I still see the issue today's treeherder. I don't know how to reproduce it, but I saw an error message on devtools console when the issue happened. Source map error: request failed with status 404 Resource URL: https://treeherder.mozilla.org/#/jobs?repo=try&revision=206574452cca9cc2a3ca9c290f04821901775afd Source Map URL: bootstrap.css.map[Learn More]

Hi! The cancel all jobs button is only shown for try repos, unless the current user is a sheriff: https://github.com/mozilla/treeherder/blob/448a568c4c92dcc5a68ea579ee66cad5c4092b2b/ui/job-view/PushHeader.jsx#L171 Was it possible the times it didn't appear were when you were on a non-try repo?

Oops, sorry. I meant on try.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0) > Source map error: request failed with status 404 Resource URL: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=206574452cca9cc2a3ca9c290f04821901775afd Source Map > URL: bootstrap.css.map[Learn More] This error message seems to be irrelevant. Now I was hit by this again, there is no error message on the console.

Any idea what might be happening here? :-)

I have not had any luck reproducing this. Though it does sound intermittent. I'm wondering if it might be a race condition where we are not getting the ``currentRepo`` value from Angular passed through to React all the time. I suspect this will be better once we're completely on React. There may be some intermittent issue with the ngReact code. Hard to say. I can add a fallback that if that object isn't defined, then we look for the substring of "try" in the repoName. I checked the DB, and this will accurately coincide with a repo being marked ``is_try_repo``. Hiroyuki: if you reload the page, does the cancel all button ever show up?

I guess the other option is to remove the non-try restriction entirely? (bug 1194467)

Philor: Do you have a feel for the danger of removing the restriction on cancel-all for non-sheriffs on non-try repos?

(In reply to Cameron Dawson [:camd] from comment #5) > Hiroyuki: if you reload the page, does the cancel all button ever show up? I guess 'yes'. I don't know it's all the time, but now I could reproduce this twice, and the button appeared after reload.

Buildbot coalescing was a feature of buildbot scheduling, which no longer exists on any tree where a developer might consider cancelling jobs. That particular reason for preventing non-sheriffs from using cancel all on non-try trees no longer applies.

Comment on attachment 8956522 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3308 Simpler and hopefully fixes the bug! :-)

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/d9026820c5a5edb448dbeaa1c5dc845a6aa79ac9 Bug 1443087 - Remove requirement of try or sheriff to cancel all jobs (#3308)