Each push is rendered in React (PR pending), but the ng-repeat for all pushes is still in angular and has an angular controller that has a fair bit of logic in it. We should convert this so that we have one over-arching react component that renders all the pushes. This may be a good time to convert the ThResultSetStore that contains all the push data into React as well, but that could be done in a separate PR.

Comment on attachment 8949603 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3206 Ed: I have not gone through to check for dead-code or CSS classes as a result of this work yet. But I broke it into commits as best I could. However, I think it's review-able, if you'd like to jump in. I'd also be happy to go through this together over Vidyo again, if you like. I will do the dead-code check tomorrow(Friday), if you would rather wait for that. Thanks for dealing with these huge PRs! :)

Ed: OK, I had some spare time tonight and went through a check for dead code. I found a couple things and pushed them up. So I think it's ready for your review. :)

Comment on attachment 8949603 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3206 Left some comments, but happy for them to be fixed without re-review :-) I've also deployed this to prototype earlier for testing.

Comment on attachment 8949603 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3206 Hey Ed: would mind taking a look at the last commit for this PR? bstack noticed that hiding runnable jobs was broken. And further testing showed a couple things were not working right there. So I had to make these changes. To get the "trigger new jobs" button to show and disappear at the correct times. Thanks!

Comment on attachment 8949603 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3206 Looks good!

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f984acf9a80082503fad4408fccce73584659256 Bug 1434677 - Convert rendering list of pushes from angular to ReactJS (#3206) This adds some new components and removes the AngularJS ng-repeat for pushes. In the course of this work, some of the AngularJS providers were converted to helper functions. In a couple cases, I had to add new code to the AngularJS areas so that it would continue to interact well between Angular and React. Also: * Rename some functions and CSS classes from resultset to push * Add unlistening for events during unmount of components

Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/597c79a224239f63bb303f934ae7225658f9cda6 Bug 1434677 - Cleanup a couple minor PushList code issues