Closed Bug 1470228 Opened 6 years ago Closed 6 years ago

improve testing for mark-as-shipped task as it's a leaf node

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mtabara, Assigned: mtabara)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Follow-up API check to ensure the release has indeed now a “shipped” state. Baked within the initial call in shipitscript.
Attachment #8989173 - Flags: review?(jlorenzo) → review+
Changes rolled-out to production. Closing this now. Will-reopen if we need to fix anything or add more stuff.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
For reference, I found a bug afterwards by doing more testing on maple. shippedAt is kept in a format on local shipitscript, while on Ship-it is kept in isoformat(). Testing that bitwise from a string perspective failed miserably here[1]. Mea culpa. Since I couldn't find a cleaner way to tweak existing local shipitscript time to be more like the Ship-it one, I went on and treated `shippedAt` case as a separate one for time comparison. PR to fix this is here[3]. currently pending review. Follow-up rerun for that particular task went on green smoothly here[2] [1]: https://taskcluster-artifacts.net/Dsl8DpRLTeaj2aIl5KPJaw/0/public/logs/live_backing.log [2]: https://taskcluster-artifacts.net/Dsl8DpRLTeaj2aIl5KPJaw/1/public/logs/live_backing.log [3]: https://github.com/mozilla-releng/shipitscript/pull/11/files
Attachment #8989173 - Flags: feedback?(sfraser) → feedback+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: