Spinboxes in Preferences and elsewhere are currently broken. Thunderbird restored them in Bug 1453233 and a few other bugs. We just need to include the correct bindings adn add the missing css. +++ This bug was initially created as a clone of Bug #1453233 +++ We removed the spinbuttons from number fields (proxy port numbers, cache size, various wait intervals) in bug 1453233 because since bug 1437302 they don't work any more. History: Removed from M-C in bug 1429573 on 10th Feb and restored in TB in March in bug 1446329.

Works but I need to split the mail part off for a separate review and also check it a bit more.

And this one does actually compile. Sorry.

Note that <resources> in xbl are gone so on trunk you need to @import the css files (see https://hg.mozilla.org/comm-central/rev/5205ff465bd3 for how Paenglab did it).

suite part for comm-central and comm-esr60. As stefanh pointed out this needs a followup bug for comm-central to cover bug 1474171. But this needs to be more global and must cover the other bindings too so I just added this to bug 1452448 for later.

Joerg, the spinbox binding needs to be preprocessed and take suite into account. Could you give this part a blessing for comm-esr60 only if ok. IanN can set approval later.

Comment on attachment 9007510 [details] [diff] [review] 1474490-spinbox-mail-esr60.patch Review of attachment 9007510 [details] [diff] [review]: ----------------------------------------------------------------- ::: common/bindings/numberbox.xml @@ +21,1 @@ > </resources> Would you mind duplicating this tag and moving it into if+else. This looks terrible ;-(

Thanks and changed. r+ from jorgk carried forward. a+ assumed.

I cannot a+ SM bugs :-( - So you'll have to organise that yourself.

Comment on attachment 9007514 [details] [diff] [review] 1474490-spinbox-mail-esr60.patch a=me

Comment on attachment 9007509 [details] [diff] [review] 1474490-spinbox.patch >+++ b/suite/base/content/communicator.css >+/******* numberboxe *******/ Nit: An extra e, should be numberbox >+textbox[type="number"] { >+ -moz-binding: url('chrome://communicator/content/bindings/numberbox.xml#numberbox'); Nit: Use " instead of ' like the rest of the file Is it worth copying the numberbox.css and spinboxes.css from TB and adapting rather than creating as new files? r/a=me with the nits fixed but easy either way with how the css files are created.

Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/b722826d2444 Restore spinbox and number boxes in SeaMonkey. r=IanN

nits fixed in push. Per irc we agreed to just create the css files and not copy them.

nit fixed esr60 version

TB 60.1 ESR, SM 2.57: https://hg.mozilla.org/releases/comm-esr60/rev/acac485cadcf937f921b86ac2db8bf8497e1b67d https://hg.mozilla.org/releases/comm-esr60/rev/7be4e20b2580e4741bef7ccb9f8f2bc2d338077e