Closed
Bug 1475101
Opened 6 years ago
Closed 6 years ago
add mark-as-started task within release graphs for Ship-it v2 roll-out
Categories
(Release Engineering :: Release Automation: Other, enhancement)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mtabara, Assigned: mtabara)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
In bug 1466627 and bug 1461668 we've enabled behaviors in shipitscript to enable `mark-as-started` task that's to send proper information from Ship-it v2 to Ship-it v1 in order to keep them in sync. All changes have landed in production, but the actual in-tree task. This bug is to track that.
More specifically:
All three patches that landed on maple that were successful in testing both behaviors are:
https://hg.mozilla.org/projects/maple/json-rev/1b38998d6310
https://hg.mozilla.org/projects/maple/json-rev/48d85c1f695f
https://hg.mozilla.org/projects/maple/json-rev/e9b94eca6ce5
On beta the mark-as-shipped tweaks looks like this - https://hg.mozilla.org/releases/mozilla-beta/rev/5ba0247433fe
What we need to ship is maple-patches sans the beta patch ^.
For mark-as-started future development when we need to roll this out: we may want to fix `Submtted by` field as it's now `shipit-scriptworker-stage`. We can feed that variable by having Ship-it v2 pass it along in the AC and then to `release-mark-as-started` task.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → mtabara
Attachment #9007898 -
Flags: review?(rail)
Assignee | ||
Comment 2•6 years ago
|
||
Leftovers:
* we still need to fix the `Submitted by` field as it'll point to `shipit-scriptworker-stage` or `prod` or something
Assignee | ||
Comment 3•6 years ago
|
||
Another leftover:
* we still need to find a way during 63 cycle to limit this patch to mozilla-beta only. But since mergeduty is 1.5months ahead, I think we're safe for now.
Comment 4•6 years ago
|
||
Comment on attachment 9007898 [details] [diff] [review]
[intree] add mark-as-started task in-tree
Review of attachment 9007898 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. I will land this on beta first and verify during the next release.
Attachment #9007898 -
Flags: review?(rail) → review+
Comment 5•6 years ago
|
||
Comment on attachment 9007898 [details] [diff] [review]
[intree] add mark-as-started task in-tree
Pushed to beta:
remote: View your change here:
remote: https://hg.mozilla.org/releases/mozilla-beta/rev/950b4168885978e03fba79c983a007ade5e50ae9
remote:
remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=950b4168885978e03fba79c983a007ade5e50ae9
remote: recorded changegroup in replication log in 0.004s
Updated•6 years ago
|
Keywords: leave-open
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 6•6 years ago
|
||
Not sure what's left to be done here - probably the proper landing of the in-tree patch for mozilla-beta only as right now I think it keeps getting overwritten by the mergeduty from central.
Am not actively working on this so I'll remove myself from asignee.
Assignee: mtabara → nobody
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e87d7028568e
add mark-as-started task. r=rail a=release
Assignee | ||
Comment 8•6 years ago
|
||
Let's track the roll-out to release/esr60 in bug 1499440.
Closing this for now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 9•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Assignee: nobody → mtabara
Updated•6 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•