Closed
Bug 1513597
Opened 6 years ago
Closed 1 year ago
Fix/enable ESLint react/forbid-prop-types
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: bolah2009)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
There are 165 instances that need fixing :-/
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md
|
Reporter | |
Comment 1•6 years ago
|
||
Example failure shown by `yarn lint` after removing the rule-disabling from .eslintrc.js:
error: Prop type `object` is forbidden (react/forbid-prop-types) at ui\job-view\pushes\Push.jsx:454:3:
452 |
453 | Push.propTypes = {
> 454 | push: PropTypes.object.isRequired,
| ^
|
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
No longer blocks: treeherder-react
|
|
||
Comment 3•5 years ago
|
||
This bug is still valid, yes. I think what we need to do is update these uses of PropTypes.object to define a shape for these props. Are you interested in working on this?
Flags: needinfo?(cdawson)
|
Assignee | |
Comment 4•5 years ago
|
||
Hi, can you assign me to this? I would like to work on it. Thanks.
Flags: needinfo?(cdawson)
|
|
||
Comment 5•5 years ago
|
||
Thanks! I appreciate you taking a crack at this. :)
Assignee: nobody → bola_ahmed2002
Flags: needinfo?(cdawson)
|
||
Comment 6•5 years ago
|
||
|
||
Comment 7•1 year ago
|
||
The linked PR was merged, and this rule is no longer turned off. Closing as fixed.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•