MUC Participants list not sorted alphabetically under some circumstances - take 2
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(Not tracked)
People
(Reporter: RyanVM, Assigned: jorgk-bmo)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
florian
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1480057 +++
Bug 1480057 fixed the lack of alphabetization under most circumstances, however the list is still not alphabetized when switching from a chat without a participants list (like a private chat) to one that does. Switching to a different public chat and back will fix the sorting.
(In reply to Florian Quèze [:florian] from bug 1480057 comment #22)
When I do that I get this JS error in the console, and I have a single nick
in the participant list:
TypeError: nicklist.getItemAtIndex(...).label is undefinedThe error is on the if (nick <
nicklist.getItemAtIndex(middle).label.toLowerCase()) line.
I guess the XBL binding isn't attached yet when we attempt to use the label
getter.
Assignee | ||
Comment 1•6 years ago
|
||
I know you didn't like this approach the last time I presented it, but do you have a better idea?
Comment 2•6 years ago
|
||
Just FYI - <richlistitem> will be (soonish) removed in bug 1512432 which may change how this loads/behaves.
Comment 3•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/611baef2655f
Bug 1480057 follow-up: Don't use .label when the XBL binding isn't attached yet. r=florian
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 6•6 years ago
|
||
TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/f3dbd71d275b715655b9facbd59e2bcac2e1f41e
Reporter | ||
Comment 7•6 years ago
|
||
Was comment 6 supposed to say b3? Just trying to figure out if the update I got today should have this fix or not (because it doesn't appear to).
Assignee | ||
Comment 8•6 years ago
|
||
Hi Ryan, no, "beta 4" is correct. That will be shipped on 29th Jan. You can pick a "preview" from our candidates directory:
http://ftp.mozilla.org/pub/thunderbird/candidates/65.0b4-candidates/build2/
Reporter | ||
Comment 9•6 years ago
|
||
Just got updated to 65.0b4 and the problem is still there.
Assignee | ||
Comment 10•6 years ago
|
||
)-: What does the error console say this time?
Reporter | ||
Comment 11•6 years ago
|
||
Nothing in the error console :(
Updated•6 years ago
|
Assignee | ||
Comment 12•6 years ago
|
||
Sorry I'm closing this now since we did land a relevant fix on TB 66 with backport to TB 65 beta 4.
It would get really confusing to do further landings here.
I'll filed bug 1532904 as follow-up.
Description
•